Re: [patch, fortran] PR fortran/52537 Optimize string comparisons against empty strings

2012-05-11 Thread Thomas Koenig
Hi Tobias, Hello Thomas, below a very timely review - your patch is not even a month old and was never pinged, besides, you have chosen an unlucky day. (In other words: Sorry for the slow review.) As a matter of fact, I had become 3/4 convinced that I had already committed this patch, which i

Re: [patch, fortran] PR fortran/52537 Optimize string comparisons against empty strings

2012-05-08 Thread Tobias Burnus
Hello Thomas, below a very timely review - your patch is not even a month old and was never pinged, besides, you have chosen an unlucky day. (In other words: Sorry for the slow review.) Thomas Koenig wrote on Fri, 13 Apr 2012: > this patch replaces a != '' with len_trim(a) != 0, to > speed up th

[patch, fortran] PR fortran/52537 Optimize string comparisons against empty strings

2012-04-13 Thread Thomas Koenig
Hello world, this patch replaces a != '' with len_trim(a) != 0, to speed up the comparison. It also introduces a bit of cleanup in frontend-passes.c. Regression-tested. OK for trunk? Thomas 2012-04-13 Thomas Koenig PR fortran/52537 * frontend-passes.c (optimize_op