Hi Tobias,
Hello Thomas,
below a very timely review - your patch is not even a month old
and was never pinged, besides, you have chosen an unlucky day.
(In other words: Sorry for the slow review.)
As a matter of fact, I had become 3/4 convinced that I had already
committed this patch, which is why I didn't ping it. So, thanks
for remembering!
Thomas Koenig wrote on Fri, 13 Apr 2012:
this patch replaces a != '' with len_trim(a) != 0, to
speed up the comparison.
I wonder how much it helps - especially for the real world
code. Let's see whether the bug reporter will report back.
We'll see.
Can you also check kind=4 string in the test case?
Added (in the second revision of the test case, I also had
a flag wrong).
Otherwise, the patch is OK.
The whitespace fixes you suggested have been applied.
Thanks for the review!
Thomas
