Re: OpenACC GIMPLE_OACC_* -- or not? (was: [gomp4 9/9] OpenACC: Basic support for #pragma acc parallel.)

On Wed, Nov 12, 2014 at 02:33:43PM +0100, Thomas Schwinge wrote: > Months later, with months' worth of GCC internals experience, I now came > to realize that maybe this has not actually been a useful thing to do > (and likewise for the GIMPLE_OACC_KERNELS also added later on, >

OpenACC GIMPLE_OACC_* -- or not? (was: [gomp4 9/9] OpenACC: Basic support for #pragma acc parallel.)

Hi! On Wed, 6 Nov 2013 20:53:00 +0100, I wrote: > --- gcc/gimple.def > +++ gcc/gimple.def > @@ -205,10 +205,16 @@ DEFGSCODE(GIMPLE_NOP, "gimple_nop", GSS_BASE) > > /* IMPORTANT. > > - Do not rearrange any of the GIMPLE_OMP_* codes. This ordering is > - exposed by the range check in gimpl

Re: [gomp4 9/9] OpenACC: Basic support for #pragma acc parallel.

Hi! On Wed, 6 Nov 2013 20:53:00 +0100, I wrote: > --- /dev/null > +++ gcc/testsuite/c-c++-common/goacc/parallel-1.c > @@ -0,0 +1,6 @@ > +void > +foo (void) > +{ > +#pragma acc parallel > + foo (); > +} Applied in r208699 on gomp-4_0-branch: commit 4a854d643b300adc0b79ad5dadd132aa1cdd535a Author

[gomp4] Gimplification: Merge gimplify_oacc_parallel into gimplify_omp_workshare. (was: [gomp4 9/9] OpenACC: Basic support for #pragma acc parallel.)

Hi! On Wed, 6 Nov 2013 20:53:00 +0100, I wrote: > gcc/ > * gimplify.c [...] > (gimplify_oacc_parallel): New function. To get rid of code duplication, I have applied the following in r208206: commit 9ffb216dd43bda84f56ce7fe68ae15cc08110924 Author: tschwinge Date: Thu Feb 27 1

Re: [gomp4 9/9] OpenACC: Basic support for #pragma acc parallel.

Hi! Thanks for the quick review of the patch series! Committed earlier today, with the revisions as discussed. On Wed, 6 Nov 2013 20:55:01 +0100, Jakub Jelinek wrote: > On Wed, Nov 06, 2013 at 08:42:23PM +0100, tho...@codesourcery.com wrote: > > +#define OACC_PARALLEL_CLAUSE_MASK

Re: [gomp4 9/9] OpenACC: Basic support for #pragma acc parallel.

On Wed, Nov 06, 2013 at 08:53:00PM +0100, Thomas Schwinge wrote: > Forgot to pass the --patience switch to Git, so the diff algorithm > decided to first patch the existing expand_omp_taskreg into > expand_oacc_parallel, and then later re-add expand_omp_taskreg. Here's a > more readable version of

Re: [gomp4 9/9] OpenACC: Basic support for #pragma acc parallel.

On Wed, Nov 06, 2013 at 08:42:23PM +0100, tho...@codesourcery.com wrote: > +#define OACC_PARALLEL_CLAUSE_MASK\ > + PRAGMA_OMP_CLAUSE_NONE This is incorrect, either you should define in c-common.h also OMP_CLAUSE_MASK_0 and define this to it, or it needs to be (OMP_CLAUSE_MA