Hi! Thanks for the quick review of the patch series! Committed earlier today, with the revisions as discussed.
On Wed, 6 Nov 2013 20:55:01 +0100, Jakub Jelinek <ja...@redhat.com> wrote: > On Wed, Nov 06, 2013 at 08:42:23PM +0100, tho...@codesourcery.com wrote: > > +#define OACC_PARALLEL_CLAUSE_MASK \ > > + PRAGMA_OMP_CLAUSE_NONE > > This is incorrect, either you should define in c-common.h > also OMP_CLAUSE_MASK_0 and define this to it, or > it needs to be (OMP_CLAUSE_MASK_1 << PRAGMA_OMP_CLAUSE_NONE). > Otherwise it won't compile on 32-bit HWI targets where omp_clause_mask > is a C++ class. You're right -- yet, thanks to the wonders of legacy C support, this doesn't even result in any compiler warning or error. Anyway, I went with your latter suggestion: this is scheduled for removal anyway, as one of my next steps is adding support for clauses for OpenACC parallel. I also notice that we're basically wasting one bit of the clause mask, because (OMP_CLAUSE_MASK_1 << PRAGMA_OMP_CLAUSE_NONE) == 1, and not 0, but as we're currently using 37 bits and have 64 bits available, that doesn't matter much (and so I didn't feel like reworking that code). Grüße, Thomas
pgpXHSDkEPVjo.pgp
Description: PGP signature
