Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-21 Thread Rainer Orth
Hi Bruce, > On Fri, Nov 18, 2016 at 9:42 AM, Mike Stump wrote: >> On Nov 18, 2016, at 2:45 AM, Rainer Orth >> wrote: >>> So the current suggestion is to combine my fixincludes patch and Jack's >>> patch to disable use if !__BLOCKS__. >> >>> I guess this is ok for mainline now to restore bootst

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-21 Thread Rainer Orth
Hi Mike, > On Nov 18, 2016, at 2:45 AM, Rainer Orth > wrote: >> So the current suggestion is to combine my fixincludes patch and Jack's >> patch to disable use if !__BLOCKS__. > >> I guess this is ok for mainline now to restore bootstrap? > > I think we are down to everyone likes this, Ok. The

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-18 Thread Bruce Korb
On Fri, Nov 18, 2016 at 9:42 AM, Mike Stump wrote: > On Nov 18, 2016, at 2:45 AM, Rainer Orth > wrote: >> So the current suggestion is to combine my fixincludes patch and Jack's >> patch to disable use if !__BLOCKS__. > >> I guess this is ok for mainline now to restore bootstrap? > > I think we

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-18 Thread Mike Stump
On Nov 18, 2016, at 2:45 AM, Rainer Orth wrote: > So the current suggestion is to combine my fixincludes patch and Jack's > patch to disable use if !__BLOCKS__. > I guess this is ok for mainline now to restore bootstrap? I think we are down to everyone likes this, Ok. The big question is, does

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-18 Thread Bruce Korb
I think restoring bootstrap is likely a good thing. On Fri, Nov 18, 2016 at 2:45 AM, Rainer Orth wrote: > > I guess this is ok for mainline now to restore bootstrap?

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-18 Thread Rainer Orth
Hi Bruce, Mike, > On Fri, Nov 11, 2016 at 3:18 AM, Mike Stump wrote: >> >> No objections from me. >> > Or me. Thanks! as discussed at length in the PR, the fixincludes route alone isn't enough to get libsanitizer to build on Darwin 15: we stay with undefined references to a function which had t

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-14 Thread Jack Howarth
Rainer, Unfortunately this permutation still fails to bootstrap on darwin15... libtool: compile: /sw/src/fink.build/gcc7-7.0.0-1/darwin_objdir/./gcc/xgcc -shared-libgcc -B/sw/src/fink.build/gcc7-7.0.0-1/darwin_objdir/./gcc -nostdinc++ -L/sw/src/fink.build/gcc7-7.0.0-1/darwin_objdir/x86_64-app

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-14 Thread Rainer Orth
Hi Jack, > In case it helps, attached is a diff of the os/trace.h header from OS X 11.11 > vs that > from MacOS X 11.12. It looks like the context of the changes that you are > trying to > apply into are different between the two OS releases and are the cause of the > build > failures on darwin

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-14 Thread Rainer Orth
Hi Jack, > > On darwin15, the proposed patch is insufficient to restore the bootstrap > > (after running genfixes in the fixincludes directory) unless I also apply > > the previously proposed change... > > no wonder: it's only been tested on darwin16. Care to explain what > error you're seein

Fwd: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-13 Thread Jack Howarth
-- Forwarded message -- From: Jack Howarth Date: Sun, Nov 13, 2016 at 1:19 PM Subject: Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267) To: Rainer Orth Cc: GCC Patches , Bruce Korb On Sun, Nov 13, 2016 at 5:53 AM, Rainer Orth wrote: > > Hi Jack, &g

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-13 Thread Rainer Orth
Hi Jack, > On darwin15, the proposed patch is insufficient to restore the bootstrap > (after running genfixes in the fixincludes directory) unless I also apply > the previously proposed change... no wonder: it's only been tested on darwin16. Care to explain what error you're seeing? Rai

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-11 Thread Bruce Korb
On Fri, Nov 11, 2016 at 3:18 AM, Mike Stump wrote: > > No objections from me. > Or me. Thanks!

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-11 Thread Rainer Orth
Hi Iain, >> On 11 Nov 2016, at 16:50, Rainer Orth wrote: >> >> Hi Iain, >> On 11 Nov 2016, at 11:18, Mike Stump wrote: On Nov 11, 2016, at 2:15 AM, Rainer Orth wrote: > The patch passes fixincludes make check (this time for real ;-) and > restores macOS 10.12 boot

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-11 Thread Iain Sandoe
> On 11 Nov 2016, at 16:50, Rainer Orth wrote: > > Hi Iain, > >>> On 11 Nov 2016, at 11:18, Mike Stump wrote: >>> >>> On Nov 11, 2016, at 2:15 AM, Rainer Orth >>> wrote: The patch passes fixincludes make check (this time for real ;-) and restores macOS 10.12 bootstrap. >>> >>> No

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-11 Thread Rainer Orth
Hi Iain, >> On 11 Nov 2016, at 11:18, Mike Stump wrote: >> >> On Nov 11, 2016, at 2:15 AM, Rainer Orth >> wrote: >>> The patch passes fixincludes make check (this time for real ;-) and >>> restores macOS 10.12 bootstrap. >> >> No objections from me. > > On x86_64-darwin14, there still seem to

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-11 Thread Iain Sandoe
Hi Rainer, Thanks for the patch! > On 11 Nov 2016, at 11:18, Mike Stump wrote: > > On Nov 11, 2016, at 2:15 AM, Rainer Orth > wrote: >> The patch passes fixincludes make check (this time for real ;-) and >> restores macOS 10.12 bootstrap. > > No objections from me. On x86_64-darwin14, there

Re: [fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-11 Thread Mike Stump
On Nov 11, 2016, at 2:15 AM, Rainer Orth wrote: > The patch passes fixincludes make check (this time for real ;-) and > restores macOS 10.12 bootstrap. No objections from me.

[fixincludes] Fix macOS 10.12 and (PR sanitizer/78267)

2016-11-11 Thread Rainer Orth
Since the recent libsanitizer import, macOS 10.12 bootstrap is broken: * unconditionally uses the Blocks extension only support by Clang without the customary #if __BLOCKS__ guard: In file included from /vol/gcc/src/hg/trunk/local/libsanitizer/sanitizer_common/sanitizer_mac.cc:39:0: /usr/incl