Hi Iain,
>> On 11 Nov 2016, at 16:50, Rainer Orth <[email protected]> wrote:
>>
>> Hi Iain,
>>
>>>> On 11 Nov 2016, at 11:18, Mike Stump <[email protected]> wrote:
>>>>
>>>> On Nov 11, 2016, at 2:15 AM, Rainer Orth <[email protected]>
>>>> wrote:
>>>>> The patch passes fixincludes make check (this time for real ;-) and
>>>>> restores macOS 10.12 bootstrap.
>>>>
>>>> No objections from me.
>>>
>>> On x86_64-darwin14, there still seem to be fails
>>>
>>> /usr/include/os/base.h
>>> /usr/include/dispatch/dispatch.h
>>> /usr/include/dispatch/object.h
>>>
>>> of kinds __has_extension() and block syntax.
>>>
>>> (I haven’t had a chance to check any other OS revs yet).
>>
>> I don't have access to anything but Darwin 11 and 16, so I can't help
>> directly.
>
> OK. Only the dispatch/ ones are present on Darwin11
>
> (did that bootstrap OK for you? if so likely 10.6 will be OK too - save me
> checking).
10.7 did without issues.
>> Maybe, if you can send (or attach to the PR) the specific
>> errors and problematic headers (or point to copies on
>> opensource.apple.com), I can help with the fixincludes part.
>
> I don’t have a Darwin16 system live at present, so can’t compare, but
> os/base.h is present on Darwin15 (so i’d expect it to be in the Darwin16
> SDK)
It is indeed.
> I’ll see if I can take an initial pass at it over the w/e and post to the PR.
Fine. I'm sure we can fix Apple's mistakes here, but it would probably
help to file bugs with them for everything we find.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
