Re: [committed] libstdc++: Support VAX floats in std::strong_order

2022-03-10 Thread Koning, Paul via Gcc-patches
> On Mar 10, 2022, at 9:27 AM, Jonathan Wakely via Gcc-patches > wrote: > > On Thu, 10 Mar 2022 at 12:16, Jonathan Wakely wrote: >> >> On Thu, 10 Mar 2022 at 11:53, Jonathan Wakely via Libstdc++ >> wrote: >>> >>> Tested x86_64-linux, and basic soundness check on vax-dec-netbsdelf. >> >> B

Re: [committed] libstdc++: Support VAX floats in std::strong_order

2022-03-10 Thread Jonathan Wakely via Gcc-patches
On Thu, 10 Mar 2022 at 12:16, Jonathan Wakely wrote: > > On Thu, 10 Mar 2022 at 11:53, Jonathan Wakely via Libstdc++ > wrote: > > > > Tested x86_64-linux, and basic soundness check on vax-dec-netbsdelf. > > But apparently not enough of a soundness check, because > isnan(__builtin_nan("")) is true

Re: [committed] libstdc++: Support VAX floats in std::strong_order

2022-03-10 Thread Jonathan Wakely via Gcc-patches
On Thu, 10 Mar 2022 at 11:53, Jonathan Wakely via Libstdc++ wrote: > > Tested x86_64-linux, and basic soundness check on vax-dec-netbsdelf. But apparently not enough of a soundness check, because isnan(__builtin_nan("")) is true for VAX, so GCC seems to have a NaN pattern, despite what I read onl

[committed] libstdc++: Support VAX floats in std::strong_order

2022-03-10 Thread Jonathan Wakely via Gcc-patches
Tested x86_64-linux, and basic soundness check on vax-dec-netbsdelf. Pushed to trunk. -- >8 -- The VAX float and double format does not support NaN, so the std::partial_ordering returned by <=> will never be 'unordered'. We can just use the partial_ordering value as the strong_ordering. libstdc