[Ping] Re: [RFC] [PATCH V2, AARCH64]: Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-12-01 Thread Venkataramanan Kumar
Hi Richard, Pinging for further comments. regards, Venkat. On 27 November 2013 14:24, Venkataramanan Kumar wrote: > Hi Richard, > >> I don't think it's good to have long lists of targets on generic tests. >> Can we factor this out into a target-supports option? > > I have updated the patch as

Re: [RFC] [PATCH V2, AARCH64]: Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-27 Thread Venkataramanan Kumar
Hi Richard, > I don't think it's good to have long lists of targets on generic tests. > Can we factor this out into a target-supports option? I have updated the patch as per your recommendation. Please let me know if it is fine. 2013-11-26 Venkataramanan Kumar * configure.ac (gcc_cv_

Re: [RFC] [PATCH V2, AARCH64]: Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-26 Thread Richard Earnshaw
On 26/11/13 14:16, Venkataramanan Kumar wrote: > Index: gcc/testsuite/gcc.dg/fstack-protector-strong.c > === > --- gcc/testsuite/gcc.dg/fstack-protector-strong.c(revision 205378) > +++ gcc/testsuite/gcc.dg/fstack-protector-strong.c

[RFC] [PATCH V2, AARCH64]: Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-26 Thread Venkataramanan Kumar
Hi Joseph/Jakub, Attached is Version 2 patch that adds machine descriptions for stack protection in Aarch64. I have removed the incorrect test case changes from the previous patch. To make GCC compatible with glibc, I have added a test for aarch64 in "GCC/configure". This tests for the glibc vers

Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-22 Thread Venkataramanan Kumar
Hi Joseph, Thank you for the detail explanation. > You need to ensure that, when new glibc is built, whatever compiler it's > built with, it continues to export the __stack_chk_guard symbol at version > GLIBC_2.17. Furthermore, if any released GCC version would generate > references to __stack_c

Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-20 Thread Joseph S. Myers
On Wed, 20 Nov 2013, Venkataramanan Kumar wrote: > > I would like to see a clear description of what happens with all eight > > combinations of (glibc version does or doesn't support this, GCC building > > glibc does or doesn't support this, GCC building user program does or > > doesn't support th

Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-20 Thread Venkataramanan Kumar
Hi Joseph, On 19 November 2013 21:53, Joseph S. Myers wrote: > On Tue, 19 Nov 2013, Jakub Jelinek wrote: > >> On Tue, Nov 19, 2013 at 04:30:21PM +0530, Venkataramanan Kumar wrote: >> > This is RFC patch that adds machine descriptions to support stack >> > smashing protection in AArch64. >> >> Mos

Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-19 Thread Joseph S. Myers
On Tue, 19 Nov 2013, Jakub Jelinek wrote: > On Tue, Nov 19, 2013 at 04:30:21PM +0530, Venkataramanan Kumar wrote: > > This is RFC patch that adds machine descriptions to support stack > > smashing protection in AArch64. > > Most of the testsuite changes look wrong. The fact that aarch64 > gets s

Re: [RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-19 Thread Jakub Jelinek
On Tue, Nov 19, 2013 at 04:30:21PM +0530, Venkataramanan Kumar wrote: > This is RFC patch that adds machine descriptions to support stack > smashing protection in AArch64. Most of the testsuite changes look wrong. The fact that aarch64 gets stack protector support doesn't mean all other targets d

[RFC] [PATCH, AARCH64] Machine descriptions to support stack smashing protection

2013-11-19 Thread Venkataramanan Kumar
Hi Maintainers, This is RFC patch that adds machine descriptions to support stack smashing protection in AArch64. I have written a very simple patch that prints "stack set" and "stack test" as template of instructions. I had 2 assumptions. 1) For "stack_protect_set" and "stack_protect_test", I