Re: [RFC/PATCH] IFN: Fix mask_{load,store} optab support macros

2020-06-24 Thread Andrew Waterman
On Wed, Jun 24, 2020 at 5:56 PM Jim Wilson wrote: > > On Wed, Jun 24, 2020 at 1:35 AM Richard Sandiford > wrote: > > Richard Biener writes: > > > AVX512 would have V16SImode and SImode because the mask would have > > > an integer mode? Likewise I could imagine RISC-V using V4SImode and > > > V

Re: [RFC/PATCH] IFN: Fix mask_{load,store} optab support macros

2020-06-24 Thread Jim Wilson
On Wed, Jun 24, 2020 at 1:35 AM Richard Sandiford wrote: > Richard Biener writes: > > AVX512 would have V16SImode and SImode because the mask would have > > an integer mode? Likewise I could imagine RISC-V using V4SImode and > > V4QImode > > or however their mask registers look like. RISC-V ha

Re: [RFC/PATCH] IFN: Fix mask_{load,store} optab support macros

2020-06-24 Thread Richard Sandiford
Jakub Jelinek writes: > On Wed, Jun 24, 2020 at 09:35:42AM +0100, Richard Sandiford wrote: >> >> I keep meaning to experiment with dropping the second mode from these >> >> optabs, >> >> since it should be uniquely determined by the first. That would make >> >> things >> >> slightly simpler and

Re: [RFC/PATCH] IFN: Fix mask_{load,store} optab support macros

2020-06-24 Thread Jakub Jelinek via Gcc-patches
On Wed, Jun 24, 2020 at 09:35:42AM +0100, Richard Sandiford wrote: > >> I keep meaning to experiment with dropping the second mode from these > >> optabs, > >> since it should be uniquely determined by the first. That would make > >> things > >> slightly simpler and more consistent with the othe

Re: [RFC/PATCH] IFN: Fix mask_{load,store} optab support macros

2020-06-24 Thread Richard Sandiford
Richard Biener writes: > On Wed, Jun 24, 2020 at 9:13 AM Richard Sandiford > wrote: >> >> "Kewen.Lin" writes: >> > Hi, >> > >> > When I am working on IFNs for vector with length, I noticed that the >> > current optab support query for mask_load/mask_store looks unexpected. >> > The mask_load/mas

Re: [RFC/PATCH] IFN: Fix mask_{load,store} optab support macros

2020-06-24 Thread Richard Biener via Gcc-patches
On Wed, Jun 24, 2020 at 9:13 AM Richard Sandiford wrote: > > "Kewen.Lin" writes: > > Hi, > > > > When I am working on IFNs for vector with length, I noticed that the > > current optab support query for mask_load/mask_store looks unexpected. > > The mask_load/mask_store requires two modes for conv

Re: [RFC/PATCH] IFN: Fix mask_{load,store} optab support macros

2020-06-24 Thread Richard Sandiford
"Kewen.Lin" writes: > Hi, > > When I am working on IFNs for vector with length, I noticed that the > current optab support query for mask_load/mask_store looks unexpected. > The mask_load/mask_store requires two modes for convert_optab query, > but the macros direct_mask_{load,store}_optab_support

[RFC/PATCH] IFN: Fix mask_{load,store} optab support macros

2020-06-23 Thread Kewen.Lin via Gcc-patches
Hi, When I am working on IFNs for vector with length, I noticed that the current optab support query for mask_load/mask_store looks unexpected. The mask_load/mask_store requires two modes for convert_optab query, but the macros direct_mask_{load,store}_optab_supported_p uses direct_optab_supported