Re: [Patch 0/X] HWASAN v3

2020-01-10 Thread Kyrill Tkachov
On 1/8/20 11:26 AM, Matthew Malcomson wrote: Hi everyone, I'm writing this email to summarise & publicise the state of this patch series, especially the difficulties around approval for GCC 10 mentioned on IRC. The main obstacle seems to be that no maintainer feels they have enough knowledge

Re: [Patch 0/X] HWASAN v3

2020-01-08 Thread Kostya Serebryany via gcc-patches
[asan/hwasan co-author here, with clearly biased opinions] On Android, HWASAN is already a fully usable testing tool. We apply it to the kernel, user space system libraries, and select apps. A phone with HWASAN-ified system is fully usable (I carry one as my primary device since March 2019). HWASA

Re: [Patch 0/X] HWASAN v3

2020-01-08 Thread Matthew Malcomson
Hi everyone, I'm writing this email to summarise & publicise the state of this patch series, especially the difficulties around approval for GCC 10 mentioned on IRC. The main obstacle seems to be that no maintainer feels they have enough knowledge about hwasan and justification that it's wort

Re: [Patch 0/X] HWASAN v3

2020-01-07 Thread Martin Liška
On 12/12/19 4:18 PM, Matthew Malcomson wrote: Hello. I've just sent few comments that are related to the v3 of the patch set. Based on the HWASAN (limited) knowledge the patch seems reasonable to me. I haven't looked much at the newly introduced RTL-hooks. But these seems to me isolated to the a

[PING] Re: [Patch 0/X] HWASAN v3

2020-01-06 Thread Matthew Malcomson
Ping On 17/12/2019 14:11, Matthew Malcomson wrote: > I've noticed a few minor problems with this patch series after I sent it > out (mostly testcase stuff, one documentation tidy-up, but also that one > patch didn't bootstrap due to something fixed in a later patch). > > I also rely on a documen

Re: [Patch 0/X] HWASAN v3

2019-12-17 Thread Matthew Malcomson
I've noticed a few minor problems with this patch series after I sent it out (mostly testcase stuff, one documentation tidy-up, but also that one patch didn't bootstrap due to something fixed in a later patch). I also rely on a documentation change that isn't part of the series. I figure I shou

[Patch 0/X] HWASAN v3

2019-12-12 Thread Matthew Malcomson
Hello, I've gone through the suggestions Martin made and implemented the ones I think I can implement for GCC10. The two functionality changes in this version are: Added the --param's hwasan-instrument-reads, hwasan-instrument-writes, hwasan-instrument-allocas, hwasan-memintrin, options. I.e. T