On 12/12/19 4:18 PM, Matthew Malcomson wrote: Hello.
I've just sent few comments that are related to the v3 of the patch set. Based on the HWASAN (limited) knowledge the patch seems reasonable to me. I haven't looked much at the newly introduced RTL-hooks. But these seems to me isolated to the aarch64 port. I can also verify that the patchset works on my aarch64 linux machine and hwasan.exp and asan.exp tests succeed.
I haven't gotten ASAN_MARK to print as HWASAN_MARK when using memory tagging, since I'm not sure the way I found to implement this would be acceptable. The inlined patch below works but it requires a special declaration instead of just an ~#include~.
Knowing that, I would not bother with the printing of HWASAN_MARK. Thanks for the series, Martin
