Re: [Patch] Not very subtle fix for pr61510

2014-07-31 Thread Jan Hubicka
> > On Mon, Jun 23, 2014 at 06:43:20PM +0100, Jan Hubicka wrote: > > > On Mon, 23 Jun 2014, James Greenhalgh wrote: > > > > > > > > > > > Hi, > > > > > > > > pr61510 is a case where cgraphunit.c::analyze_functions can end up > > > > dereferencing a NULL pointer. This is, to me, the obvious way to

Re: [Patch] Not very subtle fix for pr61510

2014-07-31 Thread James Greenhalgh
On Mon, Jun 23, 2014 at 06:43:20PM +0100, Jan Hubicka wrote: > > On Mon, 23 Jun 2014, James Greenhalgh wrote: > > > > > > > > Hi, > > > > > > pr61510 is a case where cgraphunit.c::analyze_functions can end up > > > dereferencing a NULL pointer. This is, to me, the obvious way to avoid > > > derefe

Re: [Patch] Not very subtle fix for pr61510

2014-07-04 Thread James Greenhalgh
On Mon, Jun 23, 2014 at 06:43:20PM +0100, Jan Hubicka wrote: > > On Mon, 23 Jun 2014, James Greenhalgh wrote: > > > > > > > > Hi, > > > > > > pr61510 is a case where cgraphunit.c::analyze_functions can end up > > > dereferencing a NULL pointer. This is, to me, the obvious way to avoid > > > dere

Re: [Patch] Not very subtle fix for pr61510

2014-06-23 Thread Jan Hubicka
> On Mon, 23 Jun 2014, James Greenhalgh wrote: > > > > > Hi, > > > > pr61510 is a case where cgraphunit.c::analyze_functions can end up > > dereferencing a NULL pointer. This is, to me, the obvious way to avoid > > dereferencing NULL. > > > > However, I'm not very confident that this isn't just

Re: [Patch] Not very subtle fix for pr61510

2014-06-23 Thread Richard Biener
On Mon, 23 Jun 2014, James Greenhalgh wrote: > > Hi, > > pr61510 is a case where cgraphunit.c::analyze_functions can end up > dereferencing a NULL pointer. This is, to me, the obvious way to avoid > dereferencing NULL. > > However, I'm not very confident that this isn't just masking some > horr

[Patch] Not very subtle fix for pr61510

2014-06-23 Thread James Greenhalgh
Hi, pr61510 is a case where cgraphunit.c::analyze_functions can end up dereferencing a NULL pointer. This is, to me, the obvious way to avoid dereferencing NULL. However, I'm not very confident that this isn't just masking some horrible and subtle bug, so I'd like some review feedback on the pat