On Mon, 23 Jun 2014, James Greenhalgh wrote: > > Hi, > > pr61510 is a case where cgraphunit.c::analyze_functions can end up > dereferencing a NULL pointer. This is, to me, the obvious way to avoid > dereferencing NULL. > > However, I'm not very confident that this isn't just masking some > horrible and subtle bug, so I'd like some review feedback on the patch. > > Tested on aarch64-none-elf, where I was seeing the issue. > > OK?
Obvious in some sense to me, too, but I wonder why we don't have a cgraph node for it and what happens if it is created later (and then doesn't have the flag set)? Honza? Richard. > Thanks, > James > > --- > 2014-06-19 James Greenhalgh <james.greenha...@arm.com> > > PR regression/61510 > * cgraphunit.c (analyze_functions): Check we have an origin > node before dereferencing it. > -- Richard Biener <rguent...@suse.de> SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imend"orffer
