Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior

2014-11-25 Thread Tim Shen
On Mon, Nov 24, 2014 at 3:17 AM, Jonathan Wakely wrote: > OK for trunk - thanks. Committed. :) Thanks! -- Regards, Tim Shen

Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior

2014-11-24 Thread Jonathan Wakely
On 18/11/14 11:12 -0800, Tim Shen wrote: Bootstrapped and tested. Thanks! -- Regards, Tim Shen commit f17155183b9ae1283d04f3bbdb61d05d9279ebe4 Author: timshen Date: Tue Nov 18 00:07:28 2014 -0800 PR libstdc++/63920 * include/bits/regex_executor.h: Make _M_begin non const

Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior

2014-11-19 Thread Tim Shen
On Wed, Nov 19, 2014 at 10:54 AM, Paolo Carlini wrote: > I was just aiming for consistency, from a very, very, general point of view. Not a problem. Thank you actually, since it's obviously good for us :) -- Regards, Tim Shen

Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior

2014-11-19 Thread Paolo Carlini
Hi, On 11/19/2014 07:43 PM, Daniel Krügler wrote: 2014-11-19 19:42 GMT+01:00 Tim Shen : On Wed, Nov 19, 2014 at 8:16 AM, Paolo Carlini wrote: Good. To be clear, not having carefully analyzed whatsoever, my point was more about changing _M_end too, to non-const, than about not touching _M_begi

Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior

2014-11-19 Thread Daniel Krügler
2014-11-19 19:42 GMT+01:00 Tim Shen : > On Wed, Nov 19, 2014 at 8:16 AM, Paolo Carlini > wrote: >> Good. To be clear, not having carefully analyzed whatsoever, my point was >> more about changing _M_end too, to non-const, than about not touching >> _M_begin. Would that make sense? > > Currently w

Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior

2014-11-19 Thread Tim Shen
On Wed, Nov 19, 2014 at 8:16 AM, Paolo Carlini wrote: > Good. To be clear, not having carefully analyzed whatsoever, my point was > more about changing _M_end too, to non-const, than about not touching > _M_begin. Would that make sense? Currently we never mutate _M_end. I *believe* that we still

Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior

2014-11-19 Thread Paolo Carlini
Hi Tim, On 11/19/2014 08:27 AM, Tim Shen wrote: On Tue, Nov 18, 2014 at 11:19 AM, Paolo Carlini wrote: Jonathan lately is following your work much better than me, but naively seems weird that _M_begin is non-const and _M_end is const, a different type anyway. Hmm. The current regex_search alg

Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior

2014-11-18 Thread Tim Shen
On Tue, Nov 18, 2014 at 11:19 AM, Paolo Carlini wrote: > Jonathan lately is following your work much better than me, but naively > seems weird that _M_begin is non-const and _M_end is const, a different type > anyway. Hmm. The current regex_search algorithm is implemented as try match starting fr

Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior

2014-11-18 Thread Paolo Carlini
Hi, On 11/18/2014 08:12 PM, Tim Shen wrote: Bootstrapped and tested. Jonathan lately is following your work much better than me, but naively seems weird that _M_begin is non-const and _M_end is const, a different type anyway. Paolo.

[Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior

2014-11-18 Thread Tim Shen
Bootstrapped and tested. Thanks! -- Regards, Tim Shen commit f17155183b9ae1283d04f3bbdb61d05d9279ebe4 Author: timshen Date: Tue Nov 18 00:07:28 2014 -0800 PR libstdc++/63920 * include/bits/regex_executor.h: Make _M_begin non const. * include/bits/regex_executor.tcc (