Re: [PR95416] outputs.exp: skip lto tests when not using linker plugin

2020-06-24 Thread Rainer Orth
Hi Alexandre, > On Jun 8, 2020, Alexandre Oliva wrote: > >> * outputs.exp (skip_lto): Set when missing the linker plugin. > > I withdraw the above work-around patch in favor of the fix proper below. > > It's also supposed to fix the FAILs caused by .dSYM directories on > platforms that crea

Re: [PR95416] outputs.exp: skip lto tests when not using linker plugin

2020-06-23 Thread Alexandre Oliva
On Jun 8, 2020, Alexandre Oliva wrote: > * outputs.exp (skip_lto): Set when missing the linker plugin. I withdraw the above work-around patch in favor of the fix proper below. It's also supposed to fix the FAILs caused by .dSYM directories on platforms that create them; I'd appreciate co

Re: [PR95416] outputs.exp: skip lto tests when not using linker plugin

2020-06-11 Thread Rainer Orth
ulate all too many testsuite failures on master... > Here's what I'd like to check in for now: > > [PR95416] outputs.exp: skip lto tests when not using linker plugin > > From: Alexandre Oliva > > When the linker plugin is not available, dump outputs in lto runs are > dif

Re: [PR95416] outputs.exp: skip lto tests when not using linker plugin

2020-06-10 Thread Iain Sandoe via Gcc-patches
Hi Alexandre, Alexandre Oliva wrote: On Jun 9, 2020, Iain Sandoe wrote: I have an ugly patch that makes this work for Darwin (essentially, by having two versions of the LTO tests We could deal with that in a similar way to how .dwo files are handled, namely, with explicit handling in th

Re: [PR95416] outputs.exp: skip lto tests when not using linker plugin

2020-06-10 Thread Alexandre Oliva
On Jun 9, 2020, Iain Sandoe wrote: > That means that the intermediate objects proceed all the way to .s > output - and thus the ‘final’ pass is run (producing the extra files seen). > You can mimic this with x86 Linux by appending -ffat-lto-objects to an > LTO command line. I see, thanks. >

Re: [PR95416] outputs.exp: skip lto tests when not using linker plugin

2020-06-10 Thread Alexandre Oliva
then work on the improvements with lower urgency. Here's what I'd like to check in for now: [PR95416] outputs.exp: skip lto tests when not using linker plugin From: Alexandre Oliva When the linker plugin is not available, dump outputs in lto runs are different from those output

Re: [PR95416] outputs.exp: skip lto tests when not using linker plugin

2020-06-09 Thread Rainer Orth
Hi Alexandre, > When the linker plugin is not available, dump outputs in lto runs are > different from those outputs.exp tests expect, so skip them for now. > > Regstrapped on x86_64-linux-gnu. Ok to install? > > > for gcc/testsuite/ChangeLog > > * outputs.exp (skip_lto): Set when missing

Re: [PR95416] outputs.exp: skip lto tests when not using linker plugin

2020-06-09 Thread Iain Sandoe via Gcc-patches
Hi Alexandre Alexandre Oliva wrote: When the linker plugin is not available, dump outputs in lto runs are different from those outputs.exp tests expect, so skip them for now. Targets (like Darwin too) that don’t have the linker plugin (presumably) use fat LTO objects and drive the LTO proce

[PR95416] outputs.exp: skip lto tests when not using linker plugin

2020-06-08 Thread Alexandre Oliva
When the linker plugin is not available, dump outputs in lto runs are different from those outputs.exp tests expect, so skip them for now. Regstrapped on x86_64-linux-gnu. Ok to install? for gcc/testsuite/ChangeLog * outputs.exp (skip_lto): Set when missing the linker plugin. --- t