Hi Alexandre,

> When the linker plugin is not available, dump outputs in lto runs are
> different from those outputs.exp tests expect, so skip them for now.
>
> Regstrapped on x86_64-linux-gnu.  Ok to install?
>
>
> for  gcc/testsuite/ChangeLog
>
>       * outputs.exp (skip_lto): Set when missing the linker plugin.
> ---
>  testsuite/gcc.misc-tests/outputs.exp |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git gcc/testsuite/gcc.misc-tests/outputs.exp 
> gcc/testsuite/gcc.misc-tests/outputs.exp
> index 06a32db..a47f8a6 100644
> --- gcc/testsuite/gcc.misc-tests/outputs.exp
> +++ gcc/testsuite/gcc.misc-tests/outputs.exp
> @@ -42,7 +42,8 @@ if ![check_no_compiler_messages gsplitdwarf object {
>  
>  # Check for -flto support.  We explicitly test the result to skip
>  # tests that use -flto.
> -set skip_lto ![check_effective_target_lto]
> +set skip_lto { ![check_effective_target_lto] \
> +            || ![check_linker_plugin_available] }

this is wrong unfortunately: braces are the Tcl equivalent of single
quotes so you're setting skip_lto to the string inside.  Instead you
need something like

set skip_lto [expr ![check_effective_target_lto] \
                   || ![check_linker_plugin_available]]

While this worked for me on i386-pc-solaris2.11 (both with ld, thus
without the lto plugin, and with gld and the plugin), I wonder if
there's not a better way than just skipping the lto tests, i.e. account
for the difference in expected files between the cases with and without
the plugin.

Your call in the end (perhaps as a followup): everything is better than
the current bunch of failures.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to