Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-08-05 Thread Andrew Burgess
Jeff Law writes: > On 7/29/24 6:51 AM, Andrew Burgess wrote: >> Thomas Schwinge writes: >> >>> Hi! >>> >>> On 2024-02-10T17:26:01+, Andrew Burgess wrote: --- a/libiberty/argv.c +++ b/libiberty/argv.c >>> @@ -439,17 +442,8 @@ expandargv (int *argcp, char ***argvp) } >

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-07-30 Thread Jeff Law
On 7/29/24 6:51 AM, Andrew Burgess wrote: Thomas Schwinge writes: Hi! On 2024-02-10T17:26:01+, Andrew Burgess wrote: --- a/libiberty/argv.c +++ b/libiberty/argv.c @@ -439,17 +442,8 @@ expandargv (int *argcp, char ***argvp) } /* Add a NUL terminator. */ buf

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-07-29 Thread Andrew Burgess
Thomas Schwinge writes: > Hi! > > On 2024-02-10T17:26:01+, Andrew Burgess wrote: >> --- a/libiberty/argv.c >> +++ b/libiberty/argv.c > >> @@ -439,17 +442,8 @@ expandargv (int *argcp, char ***argvp) >> } >>/* Add a NUL terminator. */ >>buffer[len] = '\0'; >> - /* If

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-07-29 Thread Thomas Schwinge
Hi! On 2024-02-10T17:26:01+, Andrew Burgess wrote: > --- a/libiberty/argv.c > +++ b/libiberty/argv.c > @@ -439,17 +442,8 @@ expandargv (int *argcp, char ***argvp) > } >/* Add a NUL terminator. */ >buffer[len] = '\0'; > - /* If the file is empty or contains only wh

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-07-16 Thread Andrew Burgess
Jeff Law writes: > On 6/11/24 4:39 AM, Andrew Burgess wrote: > >> >> Jeff, >> >> Thanks for looking these patches over. >> >> For testing, using current(ish) gcc HEAD, on x86-64 GNU/Linux, I: >> >>../src/configure --prefix=$(cd .. && pwd)/install >>make >>make check >> >> I did t

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-07-08 Thread Jeff Law
On 6/11/24 4:39 AM, Andrew Burgess wrote: Jeff, Thanks for looking these patches over. For testing, using current(ish) gcc HEAD, on x86-64 GNU/Linux, I: ../src/configure --prefix=$(cd .. && pwd)/install make make check I did this with / without my patch and then: find . -nam

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-06-28 Thread Andrew Burgess
Hi, Am I OK to push these patches given the testing went OK? I'm thinking probably, but I don't want to overstep. Thanks, Andrew Andrew Burgess writes: > Jeff Law writes: > >> On 2/10/24 10:26 AM, Andrew Burgess wrote: >>> GDB makes use of the libiberty function buildargv for splitting th

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-06-11 Thread Andrew Burgess
Jeff Law writes: > On 2/10/24 10:26 AM, Andrew Burgess wrote: >> GDB makes use of the libiberty function buildargv for splitting the >> inferior (program being debugged) argument string in the case where >> the inferior is not being started under a shell. >> >> I have recently been working to im

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-06-11 Thread Andrew Burgess
Jeff Law writes: > On 2/10/24 10:26 AM, Andrew Burgess wrote: >> GDB makes use of the libiberty function buildargv for splitting the >> inferior (program being debugged) argument string in the case where >> the inferior is not being started under a shell. >> >> I have recently been working to im

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-05-26 Thread Jeff Law
On 2/10/24 10:26 AM, Andrew Burgess wrote: GDB makes use of the libiberty function buildargv for splitting the inferior (program being debugged) argument string in the case where the inferior is not being started under a shell. I have recently been working to improve this area of GDB, and not

[PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-02-10 Thread Andrew Burgess
GDB makes use of the libiberty function buildargv for splitting the inferior (program being debugged) argument string in the case where the inferior is not being started under a shell. I have recently been working to improve this area of GDB, and noticed some unexpected behaviour to the libiberty