On 6/11/24 4:39 AM, Andrew Burgess wrote:


Jeff,

Thanks for looking these patches over.

For testing, using current(ish) gcc HEAD, on x86-64 GNU/Linux, I:

   ../src/configure --prefix=$(cd .. && pwd)/install
   make
   make check

I did this with / without my patch and then:

   find . -name "*.sum"
   ... compare all .sum files ...

There was no change in any of the .sum files.

   1. Am I correct that this will have run the bootstrap test by default?

   2. Is there any other testing I should be doing?

   3. If not, am I OK to apply both patches in this series?
Sorry, as always June is a rough month with the trunk opening for development.

Your testing of the .sum files is reasonable, assuming you used -k on the make-check step. GCC's testsuite is never really clean.

And the default target for "make" these days does a bootstrap, so you also took care of that.

So, yes, you can go ahead and commit the change.

jeff

Reply via email to