RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-25 Thread Li, Pan2
DD_IMM_FMT_3(uint8_t, 9u) > > Pan > > -Original Message- > From: Richard Biener > Sent: Friday, August 23, 2024 6:53 PM > To: Jakub Jelinek > Cc: Li, Pan2 ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for >

Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-25 Thread Richard Biener
nal Message- > From: Richard Biener > Sent: Friday, August 23, 2024 6:53 PM > To: Jakub Jelinek > Cc: Li, Pan2 ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for > vectorizable_call > > On Thu, Aug 22, 2024 at 8:36 P

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-24 Thread Li, Pan2
Friday, August 23, 2024 6:53 PM To: Jakub Jelinek Cc: Li, Pan2 ; gcc-patches@gcc.gnu.org Subject: Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call On Thu, Aug 22, 2024 at 8:36 PM Jakub Jelinek wrote: > > On Tue, Aug 20, 2024 at 01:52:35PM +0200, Richard

Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-23 Thread Richard Biener
On Thu, Aug 22, 2024 at 8:36 PM Jakub Jelinek wrote: > > On Tue, Aug 20, 2024 at 01:52:35PM +0200, Richard Biener wrote: > > On Sat, Aug 17, 2024 at 11:18 PM Jakub Jelinek wrote: > > > > > > On Sat, Aug 17, 2024 at 05:03:14AM +, Li, Pan2 wrote: > > > > Please feel free to let me know if there

Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-20 Thread Richard Biener
On Sat, Aug 17, 2024 at 11:18 PM Jakub Jelinek wrote: > > On Sat, Aug 17, 2024 at 05:03:14AM +, Li, Pan2 wrote: > > Please feel free to let me know if there is anything I can do to fix this > > issue. Thanks a lot. > > There is no bug. The operands of .{ADD,SUB,MUL}_OVERFLOW don't have to ha

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-20 Thread Li, Pan2
@rivai.ai; kito.ch...@gmail.com; jeffreya...@gmail.com; rdapp@gmail.com; Liu, Hongtao Subject: RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call Hi Pan, > -Original Message- > From: Li, Pan2 > Sent: Tuesday, August 20, 2024 1:58 AM >

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-20 Thread Tamar Christina
@gmail.com; Liu, Hongtao > Subject: RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for > vectorizable_call > > Thanks Jakub and Tamar for comments and suggestions. > > The match.pd list as below doesn't check the INT_CST type for .SAT_ADD. > > (match (u

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-19 Thread Li, Pan2
elinek Cc: Li, Pan2 ; Richard Biener ; gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@gmail.com; jeffreya...@gmail.com; rdapp@gmail.com; Liu, Hongtao Subject: RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call > -Original Message---

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-19 Thread Tamar Christina
gtao > > Subject: Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for > vectorizable_call > > On Mon, Aug 19, 2024 at 01:55:38PM +, Tamar Christina wrote: > > So would this not be the simplest fix: > > > > diff --git a/gcc/tree-vect-pattern

Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-19 Thread Jakub Jelinek
On Mon, Aug 19, 2024 at 01:55:38PM +, Tamar Christina wrote: > So would this not be the simplest fix: > > diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc > index 87b3dc413b8..fcbc83a49f0 100644 > --- a/gcc/tree-vect-patterns.cc > +++ b/gcc/tree-vect-patterns.cc > @@ -4558,6

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-19 Thread Tamar Christina
> Cc: Richard Biener ; gcc-patches@gcc.gnu.org; > juzhe.zh...@rivai.ai; kito.ch...@gmail.com; tamar.christ...@arm.com; > jeffreya...@gmail.com; rdapp....@gmail.com; Liu, Hongtao > > Subject: Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for > vectorizable_c

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-17 Thread Li, Pan2
: Sunday, August 18, 2024 5:21 AM To: Li, Pan2 Cc: Richard Biener ; gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@gmail.com; tamar.christ...@arm.com; jeffreya...@gmail.com; rdapp@gmail.com; Liu, Hongtao Subject: Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for

Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-17 Thread Jakub Jelinek
On Sat, Aug 17, 2024 at 05:03:14AM +, Li, Pan2 wrote: > Thanks Richard for confirmation. Sorry almost forget this thread. > > Please feel free to let me know if there is anything I can do to fix this > issue. Thanks a lot. There is no bug. The operands of .{ADD,SUB,MUL}_OVERFLOW don't have

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-17 Thread Jakub Jelinek
On Sat, Aug 17, 2024 at 05:03:14AM +, Li, Pan2 wrote: > Please feel free to let me know if there is anything I can do to fix this issue. Thanks a lot. There is no bug. The operands of .{ADD,SUB,MUL}_OVERFLOW don't have to have the same type, as described in the __builtin_{add,sub,mul}_overflo

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-16 Thread Li, Pan2
@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@gmail.com; tamar.christ...@arm.com; jeffreya...@gmail.com; rdapp@gmail.com; Liu, Hongtao ; Jakub Jelinek Subject: Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call On Tue, Jul 16, 2024 at 3:22 PM Li, Pan2

Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-07-16 Thread Richard Biener
_3; > version:4> > (gdb) call debug_tree (_q41) > constant > 129> > > Pan > > -Original Message- > From: Richard Biener > Sent: Wednesday, July 10, 2024 7:36 PM > To: Li, Pan2 > Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@g

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-07-16 Thread Li, Pan2
10, 2024 7:36 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@gmail.com; tamar.christ...@arm.com; jeffreya...@gmail.com; rdapp@gmail.com; Liu, Hongtao Subject: Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call On Wed, Ju

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-07-10 Thread Li, Pan2
, 2024 7:36 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@gmail.com; tamar.christ...@arm.com; jeffreya...@gmail.com; rdapp@gmail.com; Liu, Hongtao Subject: Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call On Wed, Jul 10,

Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-07-10 Thread Richard Biener
On Wed, Jul 10, 2024 at 11:28 AM wrote: > > From: Pan Li > > The .SAT_ADD has 2 operand and one of the operand may be INTEGER_CST. > For example _1 = .SAT_ADD (_2, 9) comes from below sample code. > > Form 3: > #define DEF_VEC_SAT_U_ADD_IMM_FMT_3(T, IMM) \ > T __attri

[PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-07-10 Thread pan2 . li
From: Pan Li The .SAT_ADD has 2 operand and one of the operand may be INTEGER_CST. For example _1 = .SAT_ADD (_2, 9) comes from below sample code. Form 3: #define DEF_VEC_SAT_U_ADD_IMM_FMT_3(T, IMM) \ T __attribute__((noinline))