Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-11-09 Thread Mike Stump
On Nov 9, 2013, at 5:34 AM, Bernhard Reutner-Fischer wrote: > Ok for trunk? > 2013-10-12 Bernhard Reutner-Fischer > >* lib/dg-pch.exp (pch-init): Remove pchtest check objects. Ok. The code that does set chk_lang "c++-header", but just not the code that puts in the comment, is fine

Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-11-09 Thread Bernhard Reutner-Fischer
On 1 November 2013 02:15, Mike Stump wrote: > On Oct 31, 2013, at 1:47 AM, Bernhard Reutner-Fischer > wrote: >> On 30 October 2013 23:22, Mike Stump wrote: >>> On Oct 30, 2013, at 3:14 PM, Bernhard Reutner-Fischer >>> wrote: On 30 October 2013 22:47, Mike Stump wrote: > > Was th

Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-10-31 Thread Mike Stump
On Oct 31, 2013, at 1:47 AM, Bernhard Reutner-Fischer wrote: > On 30 October 2013 23:22, Mike Stump wrote: >> On Oct 30, 2013, at 3:14 PM, Bernhard Reutner-Fischer >> wrote: >>> On 30 October 2013 22:47, Mike Stump wrote: Was there a significant purpose for the added C++ comment?

Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-10-31 Thread Bernhard Reutner-Fischer
On 30 October 2013 23:22, Mike Stump wrote: > On Oct 30, 2013, at 3:14 PM, Bernhard Reutner-Fischer > wrote: >> On 30 October 2013 22:47, Mike Stump wrote: >>> >>> Was there a significant purpose for the added C++ comment? If not, can you >>> remove that? If so, can you explain? >> >> grep -

Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-10-30 Thread Mike Stump
On Oct 30, 2013, at 3:14 PM, Bernhard Reutner-Fischer wrote: > On 30 October 2013 22:47, Mike Stump wrote: >> >> Was there a significant purpose for the added C++ comment? If not, can you >> remove that? If so, can you explain? > > grep -A9 "CONTENTS is" gcc/testsuite/lib/target-supports.ex

Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-10-30 Thread Bernhard Reutner-Fischer
On 30 October 2013 22:47, Mike Stump wrote: > On Oct 30, 2013, at 2:56 AM, Bernhard Reutner-Fischer > wrote: >> - set result [check_compile pchtest object "int i;" "-x c-header"] >> + set result [check_compile pchtest object "$chk_type" "$chk_lang"] > > the patch uses chk_type, but, I ca

Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-10-30 Thread Mike Stump
On Oct 30, 2013, at 2:56 AM, Bernhard Reutner-Fischer wrote: > - set result [check_compile pchtest object "int i;" "-x c-header"] > + set result [check_compile pchtest object "$chk_type" "$chk_lang"] the patch uses chk_type, but, I can't find where it is being set? Was there a significa

[PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-10-30 Thread Bernhard Reutner-Fischer
Hi, The pch-init leaves check objects lying around, remove them. While at it, i noticed that i was getting warnings from the check since it was invoced with xg++ -nostdinc++ on C source (in one of the two iterations the check is run -- once per tool). My suggestion is to use the correct tool to p