On Nov 9, 2013, at 5:34 AM, Bernhard Reutner-Fischer <rep.dot....@gmail.com> wrote: > Ok for trunk?
> 2013-10-12 Bernhard Reutner-Fischer <al...@gcc.gnu.org> > > * lib/dg-pch.exp (pch-init): Remove pchtest check objects. Ok. The code that does set chk_lang "c++-header", but just not the code that puts in the comment, is fine to repost as well. > Oh, and while double-checking the auto-wipe patch that i just > simplified, i encountered an inconvenient side-effect of checking > pristine trunk with plain > $ make -k check -j4 > versus my local tree with > $ make -k check -j4 RUNTESTFLAGS="-v -v -v -v " > > This bug/feature was added in a0d20ccbd97fde9c2af1f7345e3eb1313dea570f > aka svn r141337 . > From the sounds, if --target_board= is seen, then run specific test, serial. > Otherwise do the parallel stuff, i.e. check_DEJAGNU_normal_targets. > . > Still i want -v to not behave differently as not passing -v in > RUNTESTFLAGS especially regarding parallelism, so what about doing: > diff --git a/libstdc++-v3/testsuite/Makefile.am > b/libstdc++-v3/testsuite/Makefile.am > index 4c92fef..6edc410 100644 > --- a/libstdc++-v3/testsuite/Makefile.am > +++ b/libstdc++-v3/testsuite/Makefile.am > @@ -108,7 +108,7 @@ $(check_DEJAGNU_normal_targets): > check-DEJAGNUnormal%: normal%/site.exp > check-DEJAGNU $(check_DEJAGNU_normal_targets): check-DEJAGNU%: site.exp > AR="$(AR)"; export AR; \ > RANLIB="$(RANLIB)"; export RANLIB; \ > - if [ -z "$*$(filter-out --target_board=%, $(RUNTESTFLAGS))" ] \ > + if [ -z "$*$findstring --target_board=,$(RUNTESTFLAGS))" ] \ > && [ "$(filter -j, $(MFLAGS))" = "-j" ]; then \ > $(MAKE) $(AM_MAKEFLAGS) $(check_DEJAGNU_normal_targets); \ > for idx in 0 1 2 3 4 5 6 7 8 9; do \ > > This may run non-parallel if somebody has RUNTESTFLAGS=" -v -v > --target_board=" but at least we don't have -v --verbose -d --debug in > the filter-out. > Mike? Head, hurts; can you discuss with jakub. I just want to get out of the way and let you two decide what is best.
