Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-17 Thread Jakub Jelinek
On Fri, Oct 17, 2014 at 07:29:26PM +0400, Ilya Verbin wrote: > On 17 Oct 17:18, Jakub Jelinek wrote: > > On Fri, Oct 17, 2014 at 07:17:31PM +0400, Ilya Verbin wrote: > > > On 17 Oct 17:10, Jakub Jelinek wrote: > > > > Well, there is no need to remove them, just the " || (f && > > > > !omp_is_initi

Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-17 Thread Ilya Verbin
On 17 Oct 17:18, Jakub Jelinek wrote: > On Fri, Oct 17, 2014 at 07:17:31PM +0400, Ilya Verbin wrote: > > On 17 Oct 17:10, Jakub Jelinek wrote: > > > Well, there is no need to remove them, just the " || (f && > > > !omp_is_initial_device ())" > > > should be dropped from target regions without devi

Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-17 Thread Jakub Jelinek
On Fri, Oct 17, 2014 at 07:17:31PM +0400, Ilya Verbin wrote: > On 17 Oct 17:10, Jakub Jelinek wrote: > > On Fri, Oct 17, 2014 at 06:58:17PM +0400, Ilya Verbin wrote: > > > Here in the original test you have: > > > > > > #pragma omp target if (v <= 1) > > > if (omp_get_level () != 0 || (f && !o

Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-17 Thread Ilya Verbin
On 17 Oct 17:10, Jakub Jelinek wrote: > On Fri, Oct 17, 2014 at 06:58:17PM +0400, Ilya Verbin wrote: > > Here in the original test you have: > > > > #pragma omp target if (v <= 1) > > if (omp_get_level () != 0 || (f && !omp_is_initial_device ())) > > abort (); > > #pragma omp target devi

Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-17 Thread Jakub Jelinek
On Fri, Oct 17, 2014 at 06:58:17PM +0400, Ilya Verbin wrote: > Here in the original test you have: > > #pragma omp target if (v <= 1) > if (omp_get_level () != 0 || (f && !omp_is_initial_device ())) > abort (); > #pragma omp target device (d) if (v <= 1) > if (omp_get_level () != 0 ||

Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-17 Thread Ilya Verbin
On 17 Oct 16:14, Jakub Jelinek wrote: > > -volatile int v; > > +volatile int v = 0; > > Why? Ok, I'll revert it back. > > --- a/libgomp/testsuite/libgomp.c/target-7.c > > +++ b/libgomp/testsuite/libgomp.c/target-7.c > > @@ -1,7 +1,9 @@ > > +// { dg-require-effective-target offload_device } > > +

Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-17 Thread Jakub Jelinek
On Fri, Oct 17, 2014 at 06:02:11PM +0400, Ilya Verbin wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.c++/examples-4/e.53.2.C > @@ -0,0 +1,43 @@ > +// { dg-do run } > +// { dg-require-effective-target offload_device } Well, this test actually relies not only offload_device, but also on no

Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-17 Thread Ilya Verbin
On 15 Oct 17:35, Jakub Jelinek wrote: > But we do want to test them with host fallback, which those lines preclude. > Just a single dg-require-effective-target offload_device guarded test (which > there necessarily is, e.g. the 57.* ones) should be sufficient for your > purposes (if you want to dif

Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-15 Thread Jakub Jelinek
On Wed, Oct 15, 2014 at 07:28:37PM +0400, Ilya Verbin wrote: > On 15 Oct 17:05, Jakub Jelinek wrote: > > > This patch adds all examples with '#pragma omp target' from [1] to libgomp > > > testsuite. Without an accelerator or emulator, these tests are > > > UNSUPPORTED. > > > > Why? Most of the

Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-15 Thread Ilya Verbin
On 15 Oct 17:05, Jakub Jelinek wrote: > > This patch adds all examples with '#pragma omp target' from [1] to libgomp > > testsuite. Without an accelerator or emulator, these tests are UNSUPPORTED. > > Why? Most of the tests should work just fine with host fallback. > Yeah, from Examples 4.0.1 I'

Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-15 Thread Jakub Jelinek
On Wed, Oct 15, 2014 at 06:57:52PM +0400, Ilya Verbin wrote: > Hello, > > This patch adds all examples with '#pragma omp target' from [1] to libgomp > testsuite. Without an accelerator or emulator, these tests are UNSUPPORTED. Why? Most of the tests should work just fine with host fallback. Yea

[PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite

2014-10-15 Thread Ilya Verbin
Hello, This patch adds all examples with '#pragma omp target' from [1] to libgomp testsuite. Without an accelerator or emulator, these tests are UNSUPPORTED. Bootstrapped and regtested on i686-linux and x86_64-linux. Is it OK for trunk? [1] http://openmp.org/mp-documents/OpenMP_Examples_4.0.1.p