On 15 Oct 17:05, Jakub Jelinek wrote: > > This patch adds all examples with '#pragma omp target' from [1] to libgomp > > testsuite. Without an accelerator or emulator, these tests are UNSUPPORTED. > > Why? Most of the tests should work just fine with host fallback. > Yeah, from Examples 4.0.1 I'm aware of some tests which assume that host > fallback doesn't happen, but they should be in minority. > So, can you temporarily change check_effective_target_offload_device to > always return 0 from main, run the testsuite with OMP_DEFAULT_DEVICE=10000 > in the environment and see what testcases really need > { dg-require-effective-target offload_device } ?
Yes, they will work fine with host fallback, however we want to be sure that tests are running on device (or emulator). If there were some issue with offloading, and a test actually were running in fallback mode, we would never know about it. That's why we added dg-require-effective-target to all tests. Thanks, -- Ilya