Re: [PATCH 7/8] AArch64: precommit test for CMPBR instructions

2025-05-08 Thread Richard Earnshaw (lists)
On 07/05/2025 18:21, Richard Sandiford wrote: > Richard Earnshaw writes: >> On 07/05/2025 17:28, Richard Earnshaw (lists) wrote: >>> On 07/05/2025 16:54, Richard Sandiford wrote: Richard Earnshaw writes: > On 07/05/2025 13:57, Richard Sandiford wrote: >> Kyrylo Tkachov writes: >

Re: [PATCH 7/8] AArch64: precommit test for CMPBR instructions

2025-05-07 Thread Richard Sandiford
Richard Earnshaw writes: > On 07/05/2025 17:28, Richard Earnshaw (lists) wrote: >> On 07/05/2025 16:54, Richard Sandiford wrote: >>> Richard Earnshaw writes: On 07/05/2025 13:57, Richard Sandiford wrote: > Kyrylo Tkachov writes: >>> On 7 May 2025, at 12:27, Karl Meakin wrote: >

Re: [PATCH 7/8] AArch64: precommit test for CMPBR instructions

2025-05-07 Thread Richard Earnshaw (lists)
On 07/05/2025 16:54, Richard Sandiford wrote: > Richard Earnshaw writes: >> On 07/05/2025 13:57, Richard Sandiford wrote: >>> Kyrylo Tkachov writes: > On 7 May 2025, at 12:27, Karl Meakin wrote: > > Commit the test file `cmpbr.c` before rules for generating the new > instructions

Re: [PATCH 7/8] AArch64: precommit test for CMPBR instructions

2025-05-07 Thread Richard Earnshaw
On 07/05/2025 17:28, Richard Earnshaw (lists) wrote: > On 07/05/2025 16:54, Richard Sandiford wrote: >> Richard Earnshaw writes: >>> On 07/05/2025 13:57, Richard Sandiford wrote: Kyrylo Tkachov writes: >> On 7 May 2025, at 12:27, Karl Meakin wrote: >> >> Commit the test file `cm

Re: [PATCH 7/8] AArch64: precommit test for CMPBR instructions

2025-05-07 Thread Richard Sandiford
Richard Earnshaw writes: > On 07/05/2025 13:57, Richard Sandiford wrote: >> Kyrylo Tkachov writes: On 7 May 2025, at 12:27, Karl Meakin wrote: Commit the test file `cmpbr.c` before rules for generating the new instructions are added, so that the changes in codegen are more ob

Re: [PATCH 7/8] AArch64: precommit test for CMPBR instructions

2025-05-07 Thread Richard Earnshaw
On 07/05/2025 13:57, Richard Sandiford wrote: Kyrylo Tkachov writes: On 7 May 2025, at 12:27, Karl Meakin wrote: Commit the test file `cmpbr.c` before rules for generating the new instructions are added, so that the changes in codegen are more obvious in the next commit. I guess that’s an L

Re: [PATCH 7/8] AArch64: precommit test for CMPBR instructions

2025-05-07 Thread Richard Sandiford
Kyrylo Tkachov writes: >> On 7 May 2025, at 12:27, Karl Meakin wrote: >> >> Commit the test file `cmpbr.c` before rules for generating the new >> instructions are added, so that the changes in codegen are more obvious >> in the next commit. > > I guess that’s an LLVM best practice. > In GCC sinc

Re: [PATCH 7/8] AArch64: precommit test for CMPBR instructions

2025-05-07 Thread Kyrylo Tkachov
> On 7 May 2025, at 12:27, Karl Meakin wrote: > > Commit the test file `cmpbr.c` before rules for generating the new > instructions are added, so that the changes in codegen are more obvious > in the next commit. I guess that’s an LLVM best practice. In GCC since we have the check-function-bod

[PATCH 7/8] AArch64: precommit test for CMPBR instructions

2025-05-07 Thread Karl Meakin
Commit the test file `cmpbr.c` before rules for generating the new instructions are added, so that the changes in codegen are more obvious in the next commit. gcc/testsuite/ChangeLog: * gcc.target/aarch64/cmpbr.c: New test. --- gcc/testsuite/gcc.target/aarch64/cmpbr.c | 1378