Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2016-03-13 Thread Thomas Schwinge
Hi! On Thu, 30 Oct 2014 14:40:01 +0300, Ilya Verbin wrote: > This patch allows to run non-fallback 'make check-target-libgomp'. It passes > to > the host compiler additional -B options with the paths to the offload > compilers, > since non-installed host compiler doesn't know where to find mko

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2015-02-02 Thread Ilya Verbin
On 28 Jan 19:20, Ilya Verbin wrote: > On 28 Jan 17:15, Jakub Jelinek wrote: > > On Wed, Jan 28, 2015 at 07:02:59PM +0300, Ilya Verbin wrote: > > > + = XNEWVEC (char, len + sizeof ("-B" "../" DEFAULT_TARGET_MACHINE > > > +"/libgomp/")); > > > + sprintf (optional_

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2015-01-28 Thread Ilya Verbin
On 28 Jan 17:15, Jakub Jelinek wrote: > On Wed, Jan 28, 2015 at 07:02:59PM +0300, Ilya Verbin wrote: > > + = XNEWVEC (char, len + sizeof ("-B" "../" DEFAULT_TARGET_MACHINE > > + "/libgomp/")); > > + sprintf (optional_target_path2, "-B%s/../../../" > > DEFAUL

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2015-01-28 Thread Jakub Jelinek
On Wed, Jan 28, 2015 at 07:02:59PM +0300, Ilya Verbin wrote: > + = XNEWVEC (char, len + sizeof ("-B" "../" DEFAULT_TARGET_MACHINE > +"/libgomp/")); > + sprintf (optional_target_path2, "-B%s/../../../" DEFAULT_TARGET_MACHINE > +

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2015-01-28 Thread Ilya Verbin
On 15 Jan 19:58, Jakub Jelinek wrote: > On Thu, Jan 15, 2015 at 09:55:40PM +0300, Ilya Verbin wrote: > > This patch enables 'make check-target-libgomp' with noninstalled offloading > > compilers. It creates gcc/accel// directory in the build tree of > > the > > offloading compiler, this allows lt

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2015-01-15 Thread Jakub Jelinek
On Thu, Jan 15, 2015 at 09:55:40PM +0300, Ilya Verbin wrote: > This patch enables 'make check-target-libgomp' with noninstalled offloading > compilers. It creates gcc/accel// directory in the build tree of the > offloading compiler, this allows lto-wrapper to find corresponding mkoffload > in > c

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2015-01-15 Thread Ilya Verbin
On 22 Dec 13:35, Jakub Jelinek wrote: > On Mon, Dec 22, 2014 at 12:48:08PM +0100, Thomas Schwinge wrote: > > In my understanding, we'd like to support the modes that either all > > compilers are installed (which is what a user will be using), or all are > > tested from their build trees. Or, do we

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2015-01-08 Thread Thomas Schwinge
Hi! On Fri, 26 Dec 2014 22:15:24 +0300, Ilya Verbin wrote: > On 22 Dec 12:48, Thomas Schwinge wrote: > > Here is a patch to correctly match intelmic in $offload_targets; OK to > > commit, I assume? I suppose I'm the first one to ever do build-tree > > testing? (Jakub?) > OK, thanks. > I verifi

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-12-26 Thread Ilya Verbin
On 22 Dec 12:48, Thomas Schwinge wrote: > What is the reason for adding paths if $tgt_dir is empty? (I mean, if > properly installed and $tgt_dir empty, this should just work, because > that's what a user will be doing, so why does the libgomp testsuite have > to do differently?) The case for emp

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-12-22 Thread Thomas Schwinge
Hi! On Thu, 18 Dec 2014 11:21:20 +0100, Jakub Jelinek wrote: > On Wed, Dec 17, 2014 at 11:48:01PM +0100, Thomas Schwinge wrote: > > I have another suggestion: on gomp-4_0-branch, we had already started > > using a libgomp-test-support.exp file for a similar purpose. I now > > changed your code o

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-12-22 Thread Jakub Jelinek
On Mon, Dec 22, 2014 at 12:48:08PM +0100, Thomas Schwinge wrote: > In my understanding, we'd like to support the modes that either all > compilers are installed (which is what a user will be using), or all are > tested from their build trees. Or, do we also have to support the mode > that only the

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-12-22 Thread Thomas Schwinge
Hi! On Thu, 18 Dec 2014 18:41:18 +0100, Ilya Verbin wrote: > 2014-12-18 16:27 GMT+01:00 Thomas Schwinge : > > On Thu, 30 Oct 2014 14:40:01 +0300, Ilya Verbin wrote: > >> This patch allows to run non-fallback 'make check-target-libgomp'. It > >> passes to > >> the host compiler additional -B op

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-12-18 Thread Jakub Jelinek
On Thu, Dec 18, 2014 at 06:41:18PM +0100, Ilya Verbin wrote: > > What we're doing in OpenACC offloading testing (gomp-4_0-branch), is in > > the libgomp.oacc-c/c.exp (etc.) file cycle through all the available > > offloading devices, and then in there -- I think -- such options should > > be set, t

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-12-18 Thread Ilya Verbin
Hi, 2014-12-18 16:27 GMT+01:00 Thomas Schwinge : > Hi! > > On Thu, 30 Oct 2014 14:40:01 +0300, Ilya Verbin wrote: >> This patch allows to run non-fallback 'make check-target-libgomp'. It >> passes to >> the host compiler additional -B options with the paths to the offload >> compilers, >> sinc

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-12-18 Thread Thomas Schwinge
Hi! On Thu, 30 Oct 2014 14:40:01 +0300, Ilya Verbin wrote: > This patch allows to run non-fallback 'make check-target-libgomp'. It passes > to > the host compiler additional -B options with the paths to the offload > compilers, > since non-installed host compiler doesn't know where to find mko

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-12-18 Thread Jakub Jelinek
On Wed, Dec 17, 2014 at 11:48:01PM +0100, Thomas Schwinge wrote: > I have another suggestion: on gomp-4_0-branch, we had already started > using a libgomp-test-support.exp file for a similar purpose. I now > changed your code on gomp-4_0-branch in r218845 as follows (though, not > very much tested

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-12-17 Thread Thomas Schwinge
Hi! On Mon, 10 Nov 2014 17:34:30 +0300, Ilya Verbin wrote: > On 06 Nov 18:55, Jakub Jelinek wrote: > > Looks mostly good, but: > > > > > +# We need more things in site.exp, but automake completely controls the > > > +# creation of that file; there's no way to append to it without messing > > >

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-21 Thread Jakub Jelinek
On Fri, Nov 21, 2014 at 10:14:21PM +0300, Ilya Verbin wrote: > > On Fri, 21 Nov 2014 21:44:40, Ilya Verbin wrote: > > > You're right. This patch was rebased so many times, that we may forget to > > > regenerate it before committing. > > Build with liboffloadmic passed. OK for trunk? > > -- Ily

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-21 Thread Ilya Verbin
Hi Jakub! > On Fri, 21 Nov 2014 21:44:40, Ilya Verbin wrote: > > You're right. This patch was rebased so many times, that we may forget to > > regenerate it before committing. Build with liboffloadmic passed. OK for trunk? -- Ilya * Makefile.in: Regenerate. diff --git a/Makefile.i

RE: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-21 Thread Bernd Edlinger
Hi Ilya, On Fri, 21 Nov 2014 21:44:40, Ilya Verbin wrote: > > Hi, > > On 21 Nov 19:19, Bernd Edlinger wrote: >> so, did you really regenerate Makefile.in in that patch, or am I missing >> something ? > > You're right. This patch was rebased so many times, that we may forget to > regenerate it bef

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-21 Thread Ilya Verbin
Hi, On 21 Nov 19:19, Bernd Edlinger wrote: > so, did you really regenerate Makefile.in in that patch, or am I missing > something ? You're right. This patch was rebased so many times, that we may forget to regenerate it before committing. Do you plan to submit any patch for Makefile.in? Or sho

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-21 Thread Bernd Edlinger
Aehm Kirill, excuse me please, but if I do autogen Makefile.def I get this from svn diff Index: Makefile.in === --- Makefile.in    (revision 217890) +++ Makefile.in    (working copy) @@ -35238,9 +35238,6 @@ $(SHELL) $(srcdir)

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-12 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 05:34:30PM +0300, Ilya Verbin wrote: > > I don't like this, that is too fragile. If automake is changed, we'll > > forget to update this. > > If all you are about are the 3 additional variables, can't you instead > > put them into env vars and query them in the tcl code usi

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 05:34:30PM +0300, Ilya Verbin wrote: > Done, I put them into env vars. > > > > +lappend ALWAYS_CFLAGS > > > "additional_flags=${offload_additional_options}" > > > } > > > > Perhaps add this only if offload_additional_options is non-empty? > > Done. Ok (with appropr

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-10 Thread Ilya Verbin
On 06 Nov 18:55, Jakub Jelinek wrote: > Looks mostly good, but: > > > +# We need more things in site.exp, but automake completely controls the > > +# creation of that file; there's no way to append to it without messing up > > +# the dependancy chains. So we overrule automake. This rule is exact

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-06 Thread Jakub Jelinek
On Thu, Oct 30, 2014 at 02:40:01PM +0300, Ilya Verbin wrote: > 2014-10-30 Andrey Turetskiy > Ilya Verbin > > libgomp/ > * Makefile.in: Regenerate. > * configure: Regenerate. > * configure.ac: Set up offload_additional_options, > offload_additional_lib_paths a

[PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-10-30 Thread Ilya Verbin
Hello, This patch allows to run non-fallback 'make check-target-libgomp'. It passes to the host compiler additional -B options with the paths to the offload compilers, since non-installed host compiler doesn't know where to find mkoffload tools. Also in case of intelmic offload targets it appends