On Wed, Dec 17, 2014 at 11:48:01PM +0100, Thomas Schwinge wrote: > I have another suggestion: on gomp-4_0-branch, we had already started > using a libgomp-test-support.exp file for a similar purpose. I now > changed your code on gomp-4_0-branch in r218845 as follows (though, not > very much tested). The advantage here is that people who are not using > GCC build-tree testing, but are directly invoking runtest, then don't > have to set various environment variables, but instead just have to copy > this one libgomp-test-support.exp file from the build tree to the testing > tree. Does this make sense? > > commit de01639bf47e29a20959771e587fb6f30c372a45 > Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4> > Date: Wed Dec 17 22:45:05 2014 +0000 > > libgomp: Route offloading data through the libgomp-test-support.exp file. > > libgomp/ > * testsuite/Makefile.am: Don't export OFFLOAD_TARGETS, > OFFLOAD_ADDITIONAL_OPTIONS, and OFFLOAD_ADDITIONAL_LIB_PATHS... > * testsuite/libgomp-test-support.exp.in: ..., and instead set > offload_targets, offload_additional_options, and > offload_additional_lib_paths here. Update all users.
LGTM. Jakub