> I think the best place is below this:
>
> #if defined (__vxworks) && ! defined (__RTP__)
> #include
> #else
> #include
> #endif
>
> And just move the conditional from socket.c with comment.
Yes, that looks right to me.
Arno
On 8/11/2014 3:09 PM, Arnaud Charlet wrote:
>>> This patch is needed to make Ada compile for *-*-rtems*
>>> on GCC 4.8, 4.9, and the head. Is is ok to commit?
>> OK.
> Actually, these includes should go in gsocket.h, as done on other targets,
> which also answers your previous question.
Where do y
> > This patch is needed to make Ada compile for *-*-rtems*
> > on GCC 4.8, 4.9, and the head. Is is ok to commit?
>
> OK.
Actually, these includes should go in gsocket.h, as done on other targets,
which also answers your previous question.
Can you please repost an updated patch for review?
Arn
> This patch is needed to make Ada compile for *-*-rtems*
> on GCC 4.8, 4.9, and the head. Is is ok to commit?
OK.
> 2014-08-11 Joel Sherrill
>
> * socket.c: Add conditionals for RTEMS. Add include of
> and so correct prototype of gethostbyname_r() is used.
On 8/11/2014 1:15 PM, Mike Stump wrote:
> On Aug 11, 2014, at 8:08 AM, Joel Sherrill wrote:
>> +#if defined(__rtems__)
>> +#include
>> +/* Required, for read(), write(), and close() */
>> +#endif
> Strikes me as exceptionally odd. Should be done unconditionally, and any
> system that doesn’t l
On Aug 11, 2014, at 8:08 AM, Joel Sherrill wrote:
> +#if defined(__rtems__)
> +#include
> +/* Required, for read(), write(), and close() */
> +#endif
Strikes me as exceptionally odd. Should be done unconditionally, and any
system that doesn’t like that should be the odd ball.
This patch is needed to make Ada compile for *-*-rtems*
on GCC 4.8, 4.9, and the head. Is is ok to commit?
2014-08-11 Joel Sherrill
* socket.c: Add conditionals for RTEMS. Add include of
and so correct prototype of gethostbyname_r() is used.
---
gcc/ada/socket.c | 7 ++-
1
