On 8/11/2014 3:09 PM, Arnaud Charlet wrote: >>> This patch is needed to make Ada compile for *-*-rtems* >>> on GCC 4.8, 4.9, and the head. Is is ok to commit? >> OK. > Actually, these includes should go in gsocket.h, as done on other targets, > which also answers your previous question. Where do you want the include of unistd.h? It doesn't appear to be included in gsocket.h and none of the other areas specific to RTEMS make sense to add it.
I think the best place is below this: #if defined (__vxworks) && ! defined (__RTP__) #include <sys/times.h> #else #include <sys/time.h> #endif And just move the conditional from socket.c with comment. > Can you please repost an updated patch for review? No problem. > Arno -- Joel Sherrill, Ph.D. Director of Research & Development joel.sherr...@oarcorp.com On-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35805 Support Available (256) 722-9985
