Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-02-15 Thread Evandro Menezes
On 02/15/16 04:53, James Greenhalgh wrote: On Thu, Jan 21, 2016 at 04:55:40PM -0600, Evandro Menezes wrote: Got it. Let me try this again: Add support for the FCCMP insn types 2016-01-21 Evandro Menezes gcc/ * config/aarch64/aarch64.md (fccmp): Change insn type.

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-02-15 Thread James Greenhalgh
On Thu, Jan 21, 2016 at 04:55:40PM -0600, Evandro Menezes wrote: > > Got it. > > Let me try this again: > >Add support for the FCCMP insn types > >2016-01-21 Evandro Menezes > >gcc/ > * config/aarch64/aarch64.md (fccmp): Change insn type. > (fccmpe): Like

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-02-03 Thread Evandro Menezes
On 01/21/16 16:55, Evandro Menezes wrote: On 01/21/16 16:07, James Greenhalgh wrote: On Thu, Jan 21, 2016 at 01:58:31PM -0600, Evandro Menezes wrote: Hi, James. On 01/21/16 03:24, James Greenhalgh wrote: On Wed, Jan 06, 2016 at 02:44:47PM -0600, Evandro Menezes wrote: On 01/06/2016 06:04 AM,

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-21 Thread Evandro Menezes
On 01/21/16 16:07, James Greenhalgh wrote: On Thu, Jan 21, 2016 at 01:58:31PM -0600, Evandro Menezes wrote: Hi, James. On 01/21/16 03:24, James Greenhalgh wrote: On Wed, Jan 06, 2016 at 02:44:47PM -0600, Evandro Menezes wrote: On 01/06/2016 06:04 AM, Wilco Dijkstra wrote: Here's what I had i

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-21 Thread James Greenhalgh
On Thu, Jan 21, 2016 at 01:58:31PM -0600, Evandro Menezes wrote: > Hi, James. > > On 01/21/16 03:24, James Greenhalgh wrote: > >On Wed, Jan 06, 2016 at 02:44:47PM -0600, Evandro Menezes wrote: > >>On 01/06/2016 06:04 AM, Wilco Dijkstra wrote: > Here's what I had in mind when I inquired about d

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-21 Thread Evandro Menezes
On 01/21/16 13:58, Evandro Menezes wrote: Hi, James. On 01/21/16 03:24, James Greenhalgh wrote: On Wed, Jan 06, 2016 at 02:44:47PM -0600, Evandro Menezes wrote: On 01/06/2016 06:04 AM, Wilco Dijkstra wrote: Here's what I had in mind when I inquired about distinguishing FCMP from FCCMP. As y

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-21 Thread Evandro Menezes
Hi, James. On 01/21/16 03:24, James Greenhalgh wrote: On Wed, Jan 06, 2016 at 02:44:47PM -0600, Evandro Menezes wrote: On 01/06/2016 06:04 AM, Wilco Dijkstra wrote: Here's what I had in mind when I inquired about distinguishing FCMP from FCCMP. As you can see in the patch, Exynos is the only

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-21 Thread James Greenhalgh
On Thu, Jan 21, 2016 at 11:13:29AM +, Wilco Dijkstra wrote: > James Greenhalgh wrote: > > If we don't have any targets which care about the fccmps/fccmpd split in > > the code base, do we really need it? Can we just follow the example of > > fcsel? > > If we do that then we should also change

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-21 Thread Wilco Dijkstra
James Greenhalgh wrote: > If we don't have any targets which care about the fccmps/fccmpd split in > the code base, do we really need it? Can we just follow the example of > fcsel? If we do that then we should also change fcmps/d to fcmp to keep the f(c)cmp attributes orthogonal. However it seems

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-21 Thread James Greenhalgh
On Wed, Jan 06, 2016 at 02:44:47PM -0600, Evandro Menezes wrote: > Hi, Wilco. > > On 01/06/2016 06:04 AM, Wilco Dijkstra wrote: > >>Here's what I had in mind when I inquired about distinguishing FCMP from > >>FCCMP. As you can see in the patch, Exynos is the only target that > >>cares about it, b

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-20 Thread Evandro Menezes
On 01/06/16 14:44, Evandro Menezes wrote: Hi, Wilco. On 01/06/2016 06:04 AM, Wilco Dijkstra wrote: Here's what I had in mind when I inquired about distinguishing FCMP from FCCMP. As you can see in the patch, Exynos is the only target that cares about it, but I wonder if ThunderX or Xgene woul

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-06 Thread Evandro Menezes
Hi, Wilco. On 01/06/2016 06:04 AM, Wilco Dijkstra wrote: Here's what I had in mind when I inquired about distinguishing FCMP from FCCMP. As you can see in the patch, Exynos is the only target that cares about it, but I wonder if ThunderX or Xgene would too. What do you think? The new attribut

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-06 Thread Wilco Dijkstra
Hi Evandro, > Here's what I had in mind when I inquired about distinguishing FCMP from > FCCMP. As you can see in the patch, Exynos is the only target that > cares about it, but I wonder if ThunderX or Xgene would too. > > What do you think? The new attributes look fine (I've got a similar outs

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-05 Thread Andrew Pinski
> To: gcc-patches@gcc.gnu.org >>> Subject: [PATCH 2/4 v2][AArch64] Add support for FCCMP >>> >>> (v2 version removes 4 enums) >>> >>> This patch adds support for FCCMP. This is trivial with the new CCMP >>> representation - remove the restricti

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-05 Thread Evandro Menezes
Hi, Wilco. On 12/15/2015 04:32 AM, Wilco Dijkstra wrote: -Original Message- From: Wilco Dijkstra [mailto:wilco.dijks...@arm.com] Sent: 17 November 2015 18:36 To: gcc-patches@gcc.gnu.org Subject: [PATCH 2/4 v2][AArch64] Add support for FCCMP (v2 version removes 4 enums) This patch adds

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2015-12-15 Thread Bernd Schmidt
On 12/15/2015 06:20 PM, Wilco Dijkstra wrote: Adding Bernd - would you mind reviewing the ccmp.c change please? Oh sorry, didn't realize there was one in here as well. Looks ok. Bernd

RE: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2015-12-15 Thread Wilco Dijkstra
Adding Bernd - would you mind reviewing the ccmp.c change please? > -Original Message- > From: James Greenhalgh [mailto:james.greenha...@arm.com] > Sent: 15 December 2015 16:42 > To: Wilco Dijkstra > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH 2/4 v2][AArch64] Add

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2015-12-15 Thread James Greenhalgh
On Tue, Dec 15, 2015 at 10:32:50AM +, Wilco Dijkstra wrote: > ping > > > -Original Message- > > From: Wilco Dijkstra [mailto:wilco.dijks...@arm.com] > > Sent: 17 November 2015 18:36 > > To: gcc-patches@gcc.gnu.org > > Subject: [PATCH 2/4 v2][AArch64

RE: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2015-12-15 Thread Wilco Dijkstra
ping > -Original Message- > From: Wilco Dijkstra [mailto:wilco.dijks...@arm.com] > Sent: 17 November 2015 18:36 > To: gcc-patches@gcc.gnu.org > Subject: [PATCH 2/4 v2][AArch64] Add support for FCCMP > > (v2 version removes 4 enums) > > This patch adds support

[PATCH 2/4 v2][AArch64] Add support for FCCMP

2015-11-18 Thread Wilco Dijkstra
(v2 version removes 4 enums) This patch adds support for FCCMP. This is trivial with the new CCMP representation - remove the restriction of FP in ccmp.c and add FCCMP patterns. Add a test to ensure FCCMP/FCCMPE are emitted as expected. OK for commit? ChangeLog: 2015-11-18 Wilco Dijkstra