Re: [PATCH 1/4] Fix string pool statistics.

2018-11-05 Thread Richard Biener
On Mon, Nov 5, 2018 at 1:17 PM Martin Liška wrote: > > On 11/5/18 10:52 AM, Richard Biener wrote: > > On Mon, Nov 5, 2018 at 9:07 AM marxin wrote: > >> > >> > >> libcpp/ChangeLog: > > > > Hmm, the patch suggests the flag might be instead > > part of cpp_hash_table instead of each individual > > h

Re: [PATCH 1/4] Fix string pool statistics.

2018-11-05 Thread Martin Liška
ab.h | 4 +++- >> libcpp/symtab.c | 28 +++- >> 2 files changed, 22 insertions(+), 10 deletions(-) >> >From d615abbe29f0c99801de27533ec69ec63991bf8e Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 2 Nov 2018 10:51:23 +0100 Subject: [PATCH 1

Re: [PATCH 1/4] Fix string pool statistics.

2018-11-05 Thread Richard Biener
On Mon, Nov 5, 2018 at 9:07 AM marxin wrote: > > > libcpp/ChangeLog: Hmm, the patch suggests the flag might be instead part of cpp_hash_table instead of each individual ht_identifier? Or the patch is confused when it sets HT_GGC to 1 even in else -HT_STR (node) = (const unsigned char *)

[PATCH 1/4] Fix string pool statistics.

2018-11-05 Thread marxin
libcpp/ChangeLog: 2018-11-02 Martin Liska * include/symtab.h (ht_identifier): Make room for ggc flag. * symtab.c (ht_lookup_with_hash): Mark GGC and non-GGC allocated strings. (ht_dump_statistics): Use the information. --- libcpp/include/symtab.h | 4