On Mon, Nov 5, 2018 at 1:17 PM Martin Liška <mli...@suse.cz> wrote:
>
> On 11/5/18 10:52 AM, Richard Biener wrote:
> > On Mon, Nov 5, 2018 at 9:07 AM marxin <mli...@suse.cz> wrote:
> >>
> >>
> >> libcpp/ChangeLog:
> >
> > Hmm, the patch suggests the flag might be instead
> > part of cpp_hash_table instead of each individual
> > ht_identifier? Or the patch is confused when it
> > sets HT_GGC to 1 even in
> >
> > else
> > - HT_STR (node) = (const unsigned char *) obstack_copy0 (&table->stack,
> > - str, len);
> > + {
> > + HT_STR (node) = (const unsigned char *) obstack_copy0 (&table->stack,
> > + str, len);
> > + HT_GGC (node) = 1;
> > + }
> >
> > ? Do we really support mixed operation here?
>
> No, simplified in attached patch.
OK.
Thanks,
Richard.
> Martin
>
> >
> >> 2018-11-02 Martin Liska <mli...@suse.cz>
> >>
> >> * include/symtab.h (ht_identifier):
> >> Make room for ggc flag.
> >> * symtab.c (ht_lookup_with_hash): Mark
> >> GGC and non-GGC allocated strings.
> >> (ht_dump_statistics): Use the information.
> >> ---
> >> libcpp/include/symtab.h | 4 +++-
> >> libcpp/symtab.c | 28 +++++++++++++++++++---------
> >> 2 files changed, 22 insertions(+), 10 deletions(-)
> >>
