Re: [PATCH 07/18] generalize build_case_label to the rest of the compiler

2011-03-11 Thread Tom Tromey
> "Nathan" == Nathan Froyd writes: Nathan> gcc/java/ Nathan> * expr.c (expand_java_switch): Call build_case_label. Nathan> (expand_java_add_case): Likewise. The java parts are ok. FWIW, I tend to think that if a core change like this one is accepted, then updates to the fron

Re: [PATCH 07/18] generalize build_case_label to the rest of the compiler

2011-03-11 Thread Richard Guenther
On Fri, Mar 11, 2011 at 2:01 PM, Joseph S. Myers wrote: > On Thu, 10 Mar 2011, Nathan Froyd wrote: > >> This patch does lose location information on CASE_LABEL_EXPRs from the C >> family of front-ends; it did not seem worth it to have a number of >> places pass input_location when said information

Re: [PATCH 07/18] generalize build_case_label to the rest of the compiler

2011-03-11 Thread Joseph S. Myers
On Thu, 10 Mar 2011, Nathan Froyd wrote: > This patch does lose location information on CASE_LABEL_EXPRs from the C > family of front-ends; it did not seem worth it to have a number of > places pass input_location when said information isn't even used. I'm > happy to add the location_t argument b

[PATCH 07/18] generalize build_case_label to the rest of the compiler

2011-03-10 Thread Nathan Froyd
If we're going to add another TREE_OPERAND to CASE_LABEL_EXPR, then we'd have to update a number of calls to buildN or similar to know about the new operand. But that's not a good idea; the new operand is a strictly private thing and FEs in particular shouldn't have to know anything about it. Ins