On Fri, Mar 11, 2011 at 2:01 PM, Joseph S. Myers <jos...@codesourcery.com> wrote: > On Thu, 10 Mar 2011, Nathan Froyd wrote: > >> This patch does lose location information on CASE_LABEL_EXPRs from the C >> family of front-ends; it did not seem worth it to have a number of >> places pass input_location when said information isn't even used. I'm >> happy to add the location_t argument back to CASE_LABEL_EXPRs if people >> think that's worthwhile. > > Since implicit use of input_location is deprecated and should be being > phased out (making more locations explicit - including explicit > input_location until the places using it have a better location > available), I think you should keep the location argument. > > The C front-end changes in this patch series (including c-family changes) > are otherwise OK.
Yep, please pass UNKNOWN_LOCATION at callers that didn't set a location (and add a location argument to build_case_label). Thanks, Richard. > -- > Joseph S. Myers > jos...@codesourcery.com >