Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-16 Thread Jack Howarth
On Fri, Nov 16, 2012 at 08:55:52PM +0400, Alexander Potapenko wrote: > >> Also, Alexander Potapenko is the best person to ask about asan-darwin. > > > > here. > > > >> Maybe we can add him to the list of sanitizer maintainers? > > > > Seconded. At least for libsanitier/Darwin. > > > > Cheers.

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-16 Thread Alexander Potapenko
>> Also, Alexander Potapenko is the best person to ask about asan-darwin. > > here. > >> Maybe we can add him to the list of sanitizer maintainers? > > Seconded. At least for libsanitier/Darwin. > > Cheers. I can take this, but I'll be busy within the several upcoming days (till mid-next-wee

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-16 Thread Jack Howarth
On Fri, Nov 16, 2012 at 05:00:22PM +0100, Jakub Jelinek wrote: > On Fri, Nov 16, 2012 at 10:57:04AM -0500, Jack Howarth wrote: > > +case "$host" in > > + *-*-darwin*) MACH_OVERRIDE=true ;; > > + *) MACH_OVERRIDE=false ;; > > +esac > > +AM_CONDITIONAL(USING_MACH_OVERRIDE, $MACH_OVERRIDE) > > + >

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-16 Thread Jakub Jelinek
On Fri, Nov 16, 2012 at 10:57:04AM -0500, Jack Howarth wrote: > +case "$host" in > + *-*-darwin*) MACH_OVERRIDE=true ;; > + *) MACH_OVERRIDE=false ;; > +esac > +AM_CONDITIONAL(USING_MACH_OVERRIDE, $MACH_OVERRIDE) > + Shouldn't AM_CONDITIONAL follow AM_INIT_AUTOMAKE? I'd say move it before AC_CO

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-16 Thread Jack Howarth
On Fri, Nov 16, 2012 at 09:27:26AM +0100, Dodji Seketeli wrote: > Jack Howarth writes: > > > The Google branch is missing the required > > interception/mach_override/mach_override.h and > > interception/mach_override/mach_override.c files from compiler-rt svn > > for darwin. I have posted wha

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-16 Thread Jack Howarth
On Fri, Nov 16, 2012 at 09:27:26AM +0100, Dodji Seketeli wrote: > Jack Howarth writes: > > > The Google branch is missing the required > > interception/mach_override/mach_override.h and > > interception/mach_override/mach_override.c files from compiler-rt svn > > for darwin. I have posted wha

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-16 Thread Dodji Seketeli
Jack Howarth writes: > The Google branch is missing the required > interception/mach_override/mach_override.h and > interception/mach_override/mach_override.c files from compiler-rt svn > for darwin. I have posted what I believe to be the final patch which > eanbles libsanitizer on darwin...

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-15 Thread Konstantin Serebryany
I see no problems with committing mach_override to gcc. The code should be verbatim copy from llvm/projects/compiler-rt/lib/interception/mach_override Note that this code comes with an MIT license and was not developed by Google (we did add quite a few patches). Sorry for delay with replies, I am

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-15 Thread Jack Howarth
On Thu, Nov 01, 2012 at 08:52:33PM +0100, do...@redhat.com wrote: > From: Dodji Seketeli > > Hello, > > The set of patches following this message represents the work that > happened on the asan branch to build up the Address Sanitizer work > started in the Google branch. > > Address Sanitizer (

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Ian Lance Taylor
On Mon, Nov 12, 2012 at 12:39 PM, H.J. Lu wrote: > > Don't we need a bugzilla component for Sanitizer? "other"? Ian

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread H.J. Lu
On Thu, Nov 1, 2012 at 12:52 PM, wrote: > From: Dodji Seketeli > > Hello, > > The set of patches following this message represents the work that > happened on the asan branch to build up the Address Sanitizer work > started in the Google branch. > > Address Sanitizer (aka asan) is a memory error

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Jack Howarth
On Mon, Nov 12, 2012 at 06:55:32PM +0100, Dodji Seketeli wrote: > Hello Jack, > > Jack Howarth writes: > >> > >> Dodji, > >> I am finding that at r193442 bootstrapping on > >> x86_64-apple-darwin12 fails with... > > >> ../../../../gcc-4.8-20121112/libsanitizer/interception/interception_

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Jack Howarth
On Mon, Nov 12, 2012 at 06:37:06PM +0100, Tobias Burnus wrote: > Jack Howarth wrote: >> Copying over the lib/interception/mach_override directory from >> llvm.org's compiler-rt 3.2 branch into libsanitizer/interception >> allows the build of libsanitizer to proceed. I noticed that the >> mach

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Dodji Seketeli
Hello Jack, Jack Howarth writes: >> >> Dodji, >> I am finding that at r193442 bootstrapping on >> x86_64-apple-darwin12 fails with... >> ../../../../gcc-4.8-20121112/libsanitizer/interception/interception_mac.cc:16:41: >> fatal error: mach_override/mach_override.h: No such file or dire

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Tobias Burnus
Jack Howarth wrote: Copying over the lib/interception/mach_override directory from llvm.org's compiler-rt 3.2 branch into libsanitizer/interception allows the build of libsanitizer to proceed. I noticed that the mach_override subdirectory has a license file which shows... I was about to point

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Jack Howarth
On Mon, Nov 12, 2012 at 12:20:08PM -0500, Jack Howarth wrote: > On Mon, Nov 12, 2012 at 05:07:42PM +0100, Dodji Seketeli wrote: > > Following a request from Jakub, and given the fact that the patch set > > have been reviewed by Diego, I have committed the last set of patches I > > have posted to tr

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Jack Howarth
On Mon, Nov 12, 2012 at 05:07:42PM +0100, Dodji Seketeli wrote: > Following a request from Jakub, and given the fact that the patch set > have been reviewed by Diego, I have committed the last set of patches I > have posted to trunk. > > This will hopefully ease the polishing work that has started

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Konstantin Serebryany
Folks, please remember that the Clang flag has recently changed to -fsanitize=address (-fsanitize=thread). This is hopefully the last syntax change there. --kcc On Mon, Nov 12, 2012 at 8:45 AM, Tobias Burnus wrote: > Jakub Jelinek: > >> On Mon, Nov 12, 2012 at 05:07:42PM +0100, Dodji Seketeli wr

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Tobias Burnus
Jakub Jelinek: On Mon, Nov 12, 2012 at 05:07:42PM +0100, Dodji Seketeli wrote: Following a request from Jakub, and given the fact that the patch set have been reviewed by Diego, I have committed the last set of patches I have posted to trunk. Thanks, I've committed as obvious the following for

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Jakub Jelinek
On Mon, Nov 12, 2012 at 05:07:42PM +0100, Dodji Seketeli wrote: > Following a request from Jakub, and given the fact that the patch set > have been reviewed by Diego, I have committed the last set of patches I > have posted to trunk. Thanks, I've committed as obvious the following formatting clean

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-12 Thread Dodji Seketeli
Following a request from Jakub, and given the fact that the patch set have been reviewed by Diego, I have committed the last set of patches I have posted to trunk. This will hopefully ease the polishing work that has started already. I am of course watching for the fall-outs. --

Re: [PATCH 00/13] Request to merge Address Sanitizer in

2012-11-02 Thread Dodji Seketeli
do...@redhat.com writes: > The first patch is the initial import of the asan state from the > Google branch into the [asan] branch. Subsequent patches clean the > code up, add features like protection of stack and global variables, > instrumentation of memory access through built-in functions, an

[PATCH 00/13] Request to merge Address Sanitizer in

2012-11-01 Thread dodji
From: Dodji Seketeli Hello, The set of patches following this message represents the work that happened on the asan branch to build up the Address Sanitizer work started in the Google branch. Address Sanitizer (aka asan) is a memory error detector. It finds use-after-free and {heap,stack,globa