Re: [PATCH #3/7] introduce ifcombine_replace_cond

2024-11-02 Thread Alexandre Oliva
On Nov 2, 2024, Sam James wrote: > BTW, forgive the possibly silly question, but I don't see any testcases > for the series. They're in the original patch, upthread, that this series was split out of at reviewers' request. The tests all depended on a feature that was not to be included in this

Re: [PATCH #3/7] introduce ifcombine_replace_cond

2024-11-01 Thread Sam James
Alexandre Oliva writes: > Refactor ifcombine_ifandif, moving the common code from the various > paths that apply the combined condition to a new function. BTW, forgive the possibly silly question, but I don't see any testcases for the series. Would it be possible to add any? > > > for gcc/Chan

Re: [PATCH #3/7] introduce ifcombine_replace_cond

2024-11-01 Thread Alexandre Oliva
On Oct 30, 2024, Richard Biener wrote: > no need for this brace pair? No need indeed, but this bit becomes the else branch of an if introduced in #5. I figured the #5 patch would be cleaner if I kept this bit braced and indented. -- Alexandre Oliva, happy hackerhttps://FSFLA.org/b

Re: [PATCH #3/7] introduce ifcombine_replace_cond

2024-11-01 Thread Alexandre Oliva
On Oct 27, 2024, Jeff Law wrote: > On 10/25/24 5:52 AM, Alexandre Oliva wrote: >> Refactor ifcombine_ifandif, moving the common code from the various >> paths that apply the combined condition to a new function. >> >> for gcc/ChangeLog >> * tree-ssa-ifcombine.cc (ifcombine_replace_cond): Factor

Re: [PATCH #3/7] introduce ifcombine_replace_cond (was: Re: [PATCH] fold fold_truth_andor field merging into ifcombine)

2024-10-30 Thread Richard Biener
On Fri, Oct 25, 2024 at 4:39 PM Alexandre Oliva wrote: > > > Refactor ifcombine_ifandif, moving the common code from the various > paths that apply the combined condition to a new function. > > > for gcc/ChangeLog > > * tree-ssa-ifcombine.cc (ifcombine_replace_cond): Factor out >

Re: [PATCH #3/7] introduce ifcombine_replace_cond

2024-10-27 Thread Jeff Law
On 10/25/24 5:52 AM, Alexandre Oliva wrote: Refactor ifcombine_ifandif, moving the common code from the various paths that apply the combined condition to a new function. for gcc/ChangeLog * tree-ssa-ifcombine.cc (ifcombine_replace_cond): Factor out of... (ifcombin

[PATCH #3/7] introduce ifcombine_replace_cond (was: Re: [PATCH] fold fold_truth_andor field merging into ifcombine)

2024-10-25 Thread Alexandre Oliva
Refactor ifcombine_ifandif, moving the common code from the various paths that apply the combined condition to a new function. for gcc/ChangeLog * tree-ssa-ifcombine.cc (ifcombine_replace_cond): Factor out of... (ifcombine_ifandif): ... this. --- gcc/tree-ssa-ifcombin