On Oct 27, 2024, Jeff Law <[email protected]> wrote:
> On 10/25/24 5:52 AM, Alexandre Oliva wrote:
>> Refactor ifcombine_ifandif, moving the common code from the various
>> paths that apply the combined condition to a new function.
>>
>> for gcc/ChangeLog
>> * tree-ssa-ifcombine.cc (ifcombine_replace_cond): Factor out
>> of...
>> (ifcombine_ifandif): ... this.
> It looks like you also did some simplifications in
> ifcombine_ifandif. Those should be noted in the ChangeLog.
Indeed, thanks!
> Specifically you no longer make the calls to force_gimple_operand_gsi
True, they're now implied by the other force_gimple_operand_gsi_1 call.
> and simplified the equality test.
I'm not sure what you mean here. Is it about leaving the inversion for
the refactored function to perform?
If so, this addition should do:
(ifcombine_ifandif): ... this. Leave it for the above to
gimplify and invert the condition.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
