Re: [PATCH] x86: Error on -fcf-protection with incompatible target

2021-01-15 Thread Matthias Klose
On 1/14/21 4:18 PM, H.J. Lu via Gcc-patches wrote: > On Thu, Jan 14, 2021 at 6:51 AM Uros Bizjak wrote: >> >> On Thu, Jan 14, 2021 at 3:05 PM H.J. Lu wrote: >>> >>> -fcf-protection with CF_BRANCH inserts ENDBR32 at function entries. >>> ENDBR32 is NOP only on 64-bit processors and 32-bit TARGET_C

Re: [PATCH] x86: Error on -fcf-protection with incompatible target

2021-01-14 Thread H.J. Lu via Gcc-patches
64BIT > > + && !TARGET_CMOVE) > > You need TARGET_CMOV (note, no E) here. Also, please put both tests on one > line. > > LGTM with the above change. This is the patch I am checking in. Thanks. -- H.J. From c5ba570aeb0985f99ba2f723a4bc3f01801cf555 Mon Sep 17

Re: [PATCH] x86: Error on -fcf-protection with incompatible target

2021-01-14 Thread Uros Bizjak via Gcc-patches
On Thu, Jan 14, 2021 at 3:05 PM H.J. Lu wrote: > > -fcf-protection with CF_BRANCH inserts ENDBR32 at function entries. > ENDBR32 is NOP only on 64-bit processors and 32-bit TARGET_CMOVE > processors. Issue an error for -fcf-protection with CF_BRANCH when > compiling for 32-bit non-TARGET_CMOVE ta

[PATCH] x86: Error on -fcf-protection with incompatible target

2021-01-14 Thread H.J. Lu via Gcc-patches
-fcf-protection with CF_BRANCH inserts ENDBR32 at function entries. ENDBR32 is NOP only on 64-bit processors and 32-bit TARGET_CMOVE processors. Issue an error for -fcf-protection with CF_BRANCH when compiling for 32-bit non-TARGET_CMOVE targets. gcc/ PR target/98667 * config/i38