Re: [PATCH] rs6000: Fix some unexpected empty split conditions

2021-03-21 Thread Kewen.Lin via Gcc-patches
Hi Segher, on 2021/3/20 上午5:58, Segher Boessenkool wrote: > On Fri, Mar 19, 2021 at 11:50:41PM +0800, Kewen.Lin wrote: >>> I am curious if the splitters ever triggered where they should not have? >> >> Do you have any suggestion to catch this? I thought the regression >> testing probably can show

Re: [PATCH] rs6000: Fix some unexpected empty split conditions

2021-03-19 Thread Segher Boessenkool
On Fri, Mar 19, 2021 at 11:50:41PM +0800, Kewen.Lin wrote: > > I am curious if the splitters ever triggered where they should not have? > > Do you have any suggestion to catch this? I thought the regression > testing probably can show something different but it didn't unfortunately. Well, you ca

Re: [PATCH] rs6000: Fix some unexpected empty split conditions

2021-03-19 Thread Kewen.Lin via Gcc-patches
Hi Segher, Thanks for the review. on 2021/3/19 下午8:36, Segher Boessenkool wrote: > Hi! > > On Fri, Mar 19, 2021 at 10:46:54AM +0800, Kewen.Lin wrote: >> As Segher and Mike pointed out, the define_insn_and_split should avoid >> to use empty split condition if the condition for define_insn isn't e

Re: [PATCH] rs6000: Fix some unexpected empty split conditions

2021-03-19 Thread Segher Boessenkool
Hi! On Fri, Mar 19, 2021 at 10:46:54AM +0800, Kewen.Lin wrote: > As Segher and Mike pointed out, the define_insn_and_split should avoid > to use empty split condition if the condition for define_insn isn't empty, > otherwise it can sometimes leads to unexpected consequence. > > This patch is to f

[PATCH] rs6000: Fix some unexpected empty split conditions

2021-03-18 Thread Kewen.Lin via Gcc-patches
Hi, As Segher and Mike pointed out, the define_insn_and_split should avoid to use empty split condition if the condition for define_insn isn't empty, otherwise it can sometimes leads to unexpected consequence. This patch is to fix some places like this. Bootstrapped/regtested on powerpc64le-linu