Hi Segher,
on 2021/3/20 上午5:58, Segher Boessenkool wrote:
> On Fri, Mar 19, 2021 at 11:50:41PM +0800, Kewen.Lin wrote:
>>> I am curious if the splitters ever triggered where they should not have?
>>
>> Do you have any suggestion to catch this? I thought the regression
>> testing probably can show
On Fri, Mar 19, 2021 at 11:50:41PM +0800, Kewen.Lin wrote:
> > I am curious if the splitters ever triggered where they should not have?
>
> Do you have any suggestion to catch this? I thought the regression
> testing probably can show something different but it didn't unfortunately.
Well, you ca
Hi Segher,
Thanks for the review.
on 2021/3/19 下午8:36, Segher Boessenkool wrote:
> Hi!
>
> On Fri, Mar 19, 2021 at 10:46:54AM +0800, Kewen.Lin wrote:
>> As Segher and Mike pointed out, the define_insn_and_split should avoid
>> to use empty split condition if the condition for define_insn isn't e
Hi!
On Fri, Mar 19, 2021 at 10:46:54AM +0800, Kewen.Lin wrote:
> As Segher and Mike pointed out, the define_insn_and_split should avoid
> to use empty split condition if the condition for define_insn isn't empty,
> otherwise it can sometimes leads to unexpected consequence.
>
> This patch is to f
Hi,
As Segher and Mike pointed out, the define_insn_and_split should avoid
to use empty split condition if the condition for define_insn isn't empty,
otherwise it can sometimes leads to unexpected consequence.
This patch is to fix some places like this.
Bootstrapped/regtested on powerpc64le-linu