Hi,
As Segher and Mike pointed out, the define_insn_and_split should avoid
to use empty split condition if the condition for define_insn isn't empty,
otherwise it can sometimes leads to unexpected consequence.
This patch is to fix some places like this.
Bootstrapped/regtested on powerpc64le-linux-gnu P9 and
powerpc64-linux-gnu P8.
Since it's in very low risk and can avoid some unexpected errors,
is it ok for trunk? or has to be for GCC12?
BR,
Kewen
------
gcc/ChangeLog:
* config/rs6000/rs6000.md (*rotldi3_insert_sf,
*mov<SFDF:mode><SFDF2:mode>cc_p9, floatsi<mode>2_lfiwax,
floatsi<mode>2_lfiwax_mem, floatunssi<mode>2_lfiwzx,
floatunssi<mode>2_lfiwzx_mem, *floatsidf2_internal,
*floatunssidf2_internal, fix_trunc<mode>si2_stfiwx,
fix_trunc<mode>si2_internal, fixuns_trunc<mode>si2_stfiwx,
*round32<mode>2_fprs, *roundu32<mode>2_fprs,
*fix_trunc<mode>si2_internal): Fix empty split condition.
* config/rs6000/vsx.md (*vsx_le_undo_permute_<mode>,
vsx_reduc_<VEC_reduc_name>_v2df, vsx_reduc_<VEC_reduc_name>_v4sf,
*vsx_reduc_<VEC_reduc_name>_v2df_scalar,
*vsx_reduc_<VEC_reduc_name>_v4sf_scalar): Likewise.
diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
index 592ac90aa44..6ab71979566 100644
--- a/gcc/config/rs6000/rs6000.md
+++ b/gcc/config/rs6000/rs6000.md
@@ -4281,7 +4281,7 @@
(clobber (match_scratch:V4SF 4))]
"TARGET_POWERPC64 && INTVAL (operands[2]) == <bits>"
"#"
- ""
+ "&& 1"
[(parallel [(set (match_dup 5)
(zero_extend:DI (unspec:QHSI [(match_dup 3)] UNSPEC_SI_FROM_SF)))
(clobber (match_dup 4))])
@@ -5327,7 +5327,7 @@
(clobber (match_scratch:V2DI 6 "=0,&wa"))]
"TARGET_P9_MINMAX"
"#"
- ""
+ "&& 1"
[(set (match_dup 6)
(if_then_else:V2DI (match_dup 1)
(match_dup 7)
@@ -5436,7 +5436,7 @@
"TARGET_HARD_FLOAT && TARGET_LFIWAX
&& <SI_CONVERT_FP> && can_create_pseudo_p ()"
"#"
- ""
+ "&& 1"
[(pc)]
{
rtx dest = operands[0];
@@ -5476,7 +5476,7 @@
(clobber (match_scratch:DI 2 "=d,wa"))]
"TARGET_HARD_FLOAT && TARGET_LFIWAX && <SI_CONVERT_FP>"
"#"
- ""
+ "&& 1"
[(pc)]
{
operands[1] = rs6000_force_indexed_or_indirect_mem (operands[1]);
@@ -5533,7 +5533,7 @@
(clobber (match_scratch:DI 2 "=d,wa"))]
"TARGET_HARD_FLOAT && TARGET_LFIWZX && <SI_CONVERT_FP>"
"#"
- ""
+ "&& 1"
[(pc)]
{
rtx dest = operands[0];
@@ -5573,7 +5573,7 @@
(clobber (match_scratch:DI 2 "=d,wa"))]
"TARGET_HARD_FLOAT && TARGET_LFIWZX && <SI_CONVERT_FP>"
"#"
- ""
+ "&& 1"
[(pc)]
{
operands[1] = rs6000_force_indexed_or_indirect_mem (operands[1]);
@@ -5638,7 +5638,7 @@
(clobber (match_operand:SI 6 "gpc_reg_operand" "=&r"))]
"!TARGET_FCFID && TARGET_HARD_FLOAT"
"#"
- ""
+ "&& 1"
[(pc)]
{
rtx lowword, highword;
@@ -5728,7 +5728,7 @@
"!TARGET_FCFIDU && TARGET_HARD_FLOAT
&& !(TARGET_FCFID && TARGET_POWERPC64)"
"#"
- ""
+ "&& 1"
[(pc)]
{
rtx lowword, highword;
@@ -5884,7 +5884,7 @@
"TARGET_HARD_FLOAT && TARGET_STFIWX && can_create_pseudo_p ()
&& !(TARGET_P8_VECTOR && TARGET_DIRECT_MOVE)"
"#"
- ""
+ "&& 1"
[(pc)]
{
rtx dest = operands[0];
@@ -5926,7 +5926,7 @@
"TARGET_HARD_FLOAT
&& !(TARGET_P8_VECTOR && TARGET_DIRECT_MOVE)"
"#"
- ""
+ "&& 1"
[(pc)]
{
rtx lowword;
@@ -6032,7 +6032,7 @@
&& TARGET_STFIWX && can_create_pseudo_p ()
&& !TARGET_P8_VECTOR"
"#"
- ""
+ "&& 1"
[(pc)]
{
rtx dest = operands[0];
@@ -6252,7 +6252,7 @@
&& <SI_CONVERT_FP> && TARGET_LFIWAX && TARGET_STFIWX && TARGET_FCFID
&& !TARGET_DIRECT_MOVE && can_create_pseudo_p ()"
"#"
- ""
+ "&& 1"
[(pc)]
{
rtx dest = operands[0];
@@ -6285,7 +6285,7 @@
&& TARGET_LFIWZX && TARGET_STFIWX && TARGET_FCFIDU && !TARGET_DIRECT_MOVE
&& can_create_pseudo_p ()"
"#"
- ""
+ "&& 1"
[(pc)]
{
rtx dest = operands[0];
@@ -8268,7 +8268,7 @@
(clobber (match_operand:DI 5 "offsettable_mem_operand" "=o"))]
"TARGET_HARD_FLOAT && TARGET_LONG_DOUBLE_128"
"#"
- ""
+ "&& 1"
[(pc)]
{
rtx lowword;
diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md
index ad673968584..d1053ff6746 100644
--- a/gcc/config/rs6000/vsx.md
+++ b/gcc/config/rs6000/vsx.md
@@ -972,7 +972,7 @@
"@
#
xxlor %x0,%x1"
- ""
+ "&& 1"
[(set (match_dup 0) (match_dup 1))]
{
if (reload_completed && REGNO (operands[0]) == REGNO (operands[1]))
@@ -4649,7 +4649,7 @@
(clobber (match_scratch:V2DF 2 "=0,&wa"))]
"VECTOR_UNIT_VSX_P (V2DFmode)"
"#"
- ""
+ "&& 1"
[(const_int 0)]
{
rtx tmp = (GET_CODE (operands[2]) == SCRATCH)
@@ -4671,7 +4671,7 @@
(clobber (match_scratch:V4SF 3 "=&wa"))]
"VECTOR_UNIT_VSX_P (V4SFmode)"
"#"
- ""
+ "&& 1"
[(const_int 0)]
{
rtx op0 = operands[0];
@@ -4719,7 +4719,7 @@
(clobber (match_scratch:DF 2 "=0,&wa"))]
"BYTES_BIG_ENDIAN && VECTOR_UNIT_VSX_P (V2DFmode)"
"#"
- ""
+ "&& 1"
[(const_int 0)]
{
rtx hi = gen_highpart (DFmode, operands[1]);
@@ -4746,7 +4746,7 @@
(clobber (match_scratch:V4SF 4 "=0"))]
"BYTES_BIG_ENDIAN && VECTOR_UNIT_VSX_P (V4SFmode)"
"#"
- ""
+ "&& 1"
[(const_int 0)]
{
rtx op0 = operands[0];
