Re: [PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-03-10 Thread Peter Bergner via Gcc-patches
On 2/23/21 5:18 PM, Peter Bergner wrote: > On 2/23/21 4:53 PM, Segher Boessenkool wrote: >> The patch is okay for trunk and for 10. Thank you! > > Fixed and pushed to trunk. I'll push the backport after a day or two > of burn in on trunk. Thanks! Pushed to gcc10, so fixed everywhere. Peter

Re: [PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-02-23 Thread Peter Bergner via Gcc-patches
On 2/23/21 4:53 PM, Segher Boessenkool wrote: > Hi! > > On Tue, Feb 23, 2021 at 04:00:42PM -0600, Peter Bergner wrote: >> (mma_assemble_pair): Add compatibility built-in. > s/Add/New/ is better (it makes clear you do not add something to the > (already existing) mma_assemble_pair, that it is

Re: [PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-02-23 Thread Segher Boessenkool
Hi! On Tue, Feb 23, 2021 at 04:00:42PM -0600, Peter Bergner wrote: > (mma_assemble_pair): Add compatibility built-in. s/Add/New/ is better (it makes clear you do not add something to the (already existing) mma_assemble_pair, that it is in fact new here). > (mma_init_builtins): USE VSX

Re: [PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-02-23 Thread Peter Bergner via Gcc-patches
On 2/5/21 12:28 PM, Segher Boessenkool wrote: > On Fri, Feb 05, 2021 at 04:11:30PM +0100, Florian Weimer wrote: >> * Peter Bergner: >>> On 2/5/21 4:28 AM, Florian Weimer wrote: Maybe add a check that the compatibility builtins are flagged as availble using __has_builtin? >>> >>> Do you me

Re: [PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-02-05 Thread Segher Boessenkool
On Fri, Feb 05, 2021 at 04:11:30PM +0100, Florian Weimer wrote: > * Peter Bergner: > > On 2/5/21 4:28 AM, Florian Weimer wrote: > >> Maybe add a check that the compatibility builtins are flagged as > >> availble using __has_builtin? > > > > Do you mean add a test in the testsuite for this? I can c

Re: [PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-02-05 Thread Segher Boessenkool
On Thu, Feb 04, 2021 at 10:05:19PM -0600, Peter Bergner wrote: > On 2/4/21 3:16 PM, Segher Boessenkool wrote: > > On Thu, Feb 04, 2021 at 02:40:20PM -0600, Peter Bergner wrote: > >> The LLVM and GCC teams agreed to rename the __builtin_mma_assemble_pair and > >> __builtin_mma_disassemble_pair built

Re: [PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-02-05 Thread Florian Weimer via Gcc-patches
* Peter Bergner: > On 2/5/21 4:28 AM, Florian Weimer wrote: >> * Peter Bergner via Gcc-patches: >> >>> The LLVM and GCC teams agreed to rename the __builtin_mma_assemble_pair and >>> __builtin_mma_disassemble_pair built-ins to __builtin_vsx_assemble_pair and >>> __builtin_vsx_disassemble_pair res

Re: [PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-02-05 Thread Peter Bergner via Gcc-patches
On 2/5/21 4:28 AM, Florian Weimer wrote: > * Peter Bergner via Gcc-patches: > >> The LLVM and GCC teams agreed to rename the __builtin_mma_assemble_pair and >> __builtin_mma_disassemble_pair built-ins to __builtin_vsx_assemble_pair and >> __builtin_vsx_disassemble_pair respectively. It's too late

Re: [PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-02-05 Thread Florian Weimer via Gcc-patches
* Peter Bergner via Gcc-patches: > The LLVM and GCC teams agreed to rename the __builtin_mma_assemble_pair and > __builtin_mma_disassemble_pair built-ins to __builtin_vsx_assemble_pair and > __builtin_vsx_disassemble_pair respectively. It's too late to remove the > old names, so this patch adds s

Re: [PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-02-04 Thread Peter Bergner via Gcc-patches
On 2/4/21 3:16 PM, Segher Boessenkool wrote: > Hi! > > On Thu, Feb 04, 2021 at 02:40:20PM -0600, Peter Bergner wrote: >> The LLVM and GCC teams agreed to rename the __builtin_mma_assemble_pair and >> __builtin_mma_disassemble_pair built-ins to __builtin_vsx_assemble_pair and >> __builtin_vsx_disas

Re: [PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-02-04 Thread Segher Boessenkool
Hi! On Thu, Feb 04, 2021 at 02:40:20PM -0600, Peter Bergner wrote: > The LLVM and GCC teams agreed to rename the __builtin_mma_assemble_pair and > __builtin_mma_disassemble_pair built-ins to __builtin_vsx_assemble_pair and > __builtin_vsx_disassemble_pair respectively. It's too late to remove the

[PATCH] rs6000: Fix MMA API - Add support for compatibility built-ins

2021-02-04 Thread Peter Bergner via Gcc-patches
The LLVM and GCC teams agreed to rename the __builtin_mma_assemble_pair and __builtin_mma_disassemble_pair built-ins to __builtin_vsx_assemble_pair and __builtin_vsx_disassemble_pair respectively. It's too late to remove the old names, so this patch adds support for creating compatibility built-in