Hi! On Thu, Feb 04, 2021 at 02:40:20PM -0600, Peter Bergner wrote: > The LLVM and GCC teams agreed to rename the __builtin_mma_assemble_pair and > __builtin_mma_disassemble_pair built-ins to __builtin_vsx_assemble_pair and > __builtin_vsx_disassemble_pair respectively. It's too late to remove the > old names, so this patch adds support for creating compatibility built-ins > (ie, multiple built-in functions generate the same code) and then creates > compatibility built-ins using the new names.
This needs a documentation update. You can just delete the old names there (i.e. rename everything there). > This passed bootstrap and regtesting on powerpc64le-linux with no regressions. > Ok for mainline? Some comments: > +#ifndef RS6000_BUILTIN_COMPAT > + #undef BU_COMPAT > + #define BU_COMPAT(ENUM, COMPAT_NAME) Please do not do #undef unless necessary: it hides bugs (and that causes more bugs). > BU_MMA_3 (ASSEMBLE_PAIR, "assemble_pair", MISC, mma_assemble_pair) > +BU_COMPAT (MMA_BUILTIN_ASSEMBLE_PAIR, "vsx_assemble_pair") You should do those the other way around (the mma_ one is the compatibility one). This matters, because if you disable the compatibility builtins the vsx_ one should still be there, but not the old name. (It also makes more sense of course). Okay for trunk with that fixed. Also okay for gcc-10 after watching a week or so for fallout. Thanks! Segher
