Re: [PATCH] libstdc++ testsuite: Correct S0 in std/time/hh_mm_ss/1.cc

2023-02-01 Thread Hans-Peter Nilsson via Gcc-patches
> From: Jonathan Wakely > Date: Wed, 1 Feb 2023 18:19:09 +0100 > On Wed, 1 Feb 2023 at 16:01, Jonathan Wakely wrote: > > > > On Wed, 1 Feb 2023 at 14:38, Hans-Peter Nilsson via Libstdc++ > > wrote: > > > > > > Tested cris-elf and native x86_64-pc-linux-gnu. > > > Ok to commit? > > > > OK, thanks

Re: [PATCH] libstdc++ testsuite: Correct S0 in std/time/hh_mm_ss/1.cc

2023-02-01 Thread Jonathan Wakely via Gcc-patches
On Wed, 1 Feb 2023 at 16:01, Jonathan Wakely wrote: > > On Wed, 1 Feb 2023 at 14:38, Hans-Peter Nilsson via Libstdc++ > wrote: > > > > Tested cris-elf and native x86_64-pc-linux-gnu. > > Ok to commit? > > OK, thanks. We could add the [[no_unique_address]] attribute to the _M_ss member, so that it

Re: [PATCH] libstdc++ testsuite: Correct S0 in std/time/hh_mm_ss/1.cc

2023-02-01 Thread Jonathan Wakely via Gcc-patches
On Wed, 1 Feb 2023 at 14:38, Hans-Peter Nilsson via Libstdc++ wrote: > > Tested cris-elf and native x86_64-pc-linux-gnu. > Ok to commit? OK, thanks.

[PATCH] libstdc++ testsuite: Correct S0 in std/time/hh_mm_ss/1.cc

2023-02-01 Thread Hans-Peter Nilsson via Gcc-patches
Tested cris-elf and native x86_64-pc-linux-gnu. Ok to commit? -8< -- For targets where the ABI mandates structure layout that has no padding, like cris-elf, this test started failing when introduced as an add-on to the existing 1.cc, thereby effectively causing a regression in testsuite r