> From: Jonathan Wakely <jwak...@redhat.com> > Date: Wed, 1 Feb 2023 18:19:09 +0100
> On Wed, 1 Feb 2023 at 16:01, Jonathan Wakely wrote: > > > > On Wed, 1 Feb 2023 at 14:38, Hans-Peter Nilsson via Libstdc++ > > <libstd...@gcc.gnu.org> wrote: > > > > > > Tested cris-elf and native x86_64-pc-linux-gnu. > > > Ok to commit? > > > > OK, thanks. > > We could add the [[no_unique_address]] attribute to the _M_ss member, > so that it takes no space when it's an empty struct. > > That would save a byte in hh_mm_ss for cris-elf and targets like that, > but as this type isn't meant to be used for storage, I don't think we > should bother. People shouldn't be using this as a data member, just > creating it on the stack and then discarding it. > Agreed; no worries. Thanks for the review. brgds, H-P
