Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-06-04 Thread Jonathan Wakely
On 28/05/25 15:20 -0400, Patrick Palka wrote: Change in this version: * Add test using an integer-class distance type, based on views::iota. OK for trunk, thank you both for all the work on this! -- >8 -- This implements ranges::starts_with and ranges::ends_with from the C++23 paper P1659R

Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-28 Thread Tomasz Kaminski
On Wed, May 28, 2025 at 9:20 PM Patrick Palka wrote: > Change in this version: > > * Add test using an integer-class distance type, based on views::iota. > > -- >8 -- > > This implements ranges::starts_with and ranges::ends_with from the C++23 > paper P1659R3. The logic of these algorithms is

[PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-28 Thread Patrick Palka
Change in this version: * Add test using an integer-class distance type, based on views::iota. -- >8 -- This implements ranges::starts_with and ranges::ends_with from the C++23 paper P1659R3. The logic of these algorithms is contained in an _S_impl member function that takes optional size par

Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-19 Thread Patrick Palka
On Mon, 19 May 2025, Tomasz Kaminski wrote: > > > On Mon, May 19, 2025 at 9:59 AM Tomasz Kaminski wrote: > > > On Mon, May 19, 2025 at 6:47 AM Patrick Palka wrote: > I would appreciate a short explanation on the approach being put here,  > in the message. Like passing -1 as means of saying,

Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-19 Thread Tomasz Kaminski
On Mon, May 19, 2025 at 4:09 PM Tomasz Kaminski wrote: > > > On Mon, May 19, 2025 at 4:02 PM Patrick Palka wrote: > >> On Mon, 19 May 2025, Tomasz Kaminski wrote: >> >> > >> > >> > On Mon, May 19, 2025 at 6:47 AM Patrick Palka >> wrote: >> > I would appreciate a short explanation on the approac

Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-19 Thread Tomasz Kaminski
On Mon, May 19, 2025 at 4:05 PM Patrick Palka wrote: > On Mon, 19 May 2025, Tomasz Kaminski wrote: > > > > > > > On Mon, May 19, 2025 at 9:59 AM Tomasz Kaminski > wrote: > > > > > > On Mon, May 19, 2025 at 6:47 AM Patrick Palka wrote: > > I would appreciate a short explanation on the approach b

Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-19 Thread Tomasz Kaminski
On Mon, May 19, 2025 at 4:02 PM Patrick Palka wrote: > On Mon, 19 May 2025, Tomasz Kaminski wrote: > > > > > > > On Mon, May 19, 2025 at 6:47 AM Patrick Palka wrote: > > I would appreciate a short explanation on the approach being put here, > > in the message. Like passing -1 as means of saying,

Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-19 Thread Patrick Palka
On Mon, 19 May 2025, Tomasz Kaminski wrote: > > > On Mon, May 19, 2025 at 6:47 AM Patrick Palka wrote: > I would appreciate a short explanation on the approach being put here,  > in the message. Like passing -1 as means of saying, size not know. > > Tested on x86_64-pc-linux-gnu, does th

Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-19 Thread Tomasz Kaminski
On Mon, May 19, 2025 at 9:59 AM Tomasz Kaminski wrote: > > > On Mon, May 19, 2025 at 6:47 AM Patrick Palka wrote: > I would appreciate a short explanation on the approach being put here, > in the message. Like passing -1 as means of saying, size not know. > > Tested on x86_64-pc-linux-gnu, does

Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-19 Thread Jonathan Wakely
On Mon, 19 May 2025 at 10:35, Tomasz Kaminski wrote: > > > > On Mon, May 19, 2025 at 11:29 AM Jonathan Wakely wrote: >> >> On Mon, 19 May 2025 at 05:46, Patrick Palka wrote: >> > >> > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? >> > >> > -- >8 -- >> > >> > libstdc++-v3/ChangeLog:

Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-19 Thread Jonathan Wakely
On Mon, 19 May 2025 at 05:46, Patrick Palka wrote: > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? > > -- >8 -- > > libstdc++-v3/ChangeLog: > > * include/bits/ranges_algo.h (__starts_with_fn, starts_with): > Define. > (__ends_with_fn, ends_with): Define. >

Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-19 Thread Tomasz Kaminski
On Mon, May 19, 2025 at 11:29 AM Jonathan Wakely wrote: > On Mon, 19 May 2025 at 05:46, Patrick Palka wrote: > > > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? > > > > -- >8 -- > > > > libstdc++-v3/ChangeLog: > > > > * include/bits/ranges_algo.h (__starts_with_fn, starts

Re: [PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-19 Thread Tomasz Kaminski
On Mon, May 19, 2025 at 6:47 AM Patrick Palka wrote: I would appreciate a short explanation on the approach being put here, in the message. Like passing -1 as means of saying, size not know. Tested on x86_64-pc-linux-gnu, does this look OK for trunk? > >From the non-stylistic changes, I have noti

[PATCH] libstdc++: Implement C++23 P1659R3 starts_with and ends_with

2025-05-18 Thread Patrick Palka
Tested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- libstdc++-v3/ChangeLog: * include/bits/ranges_algo.h (__starts_with_fn, starts_with): Define. (__ends_with_fn, ends_with): Define. * include/bits/version.def (ranges_starts_ends_with): Define.