Re: [PATCH] gcc.misc-tests/outputs.exp: assert unique test-names

2021-03-03 Thread Alexandre Oliva
On Feb 25, 2021, Hans-Peter Nilsson wrote: > Navigating and debugging causes for failing tests here isn't > helped by the existence of tests with duplicate names. Aah, I guess I see what happened: some test sets were copied to cover additional cases I hadn't covered (cool :-), but the test names

Re: [PATCH] gcc.misc-tests/outputs.exp: assert unique test-names

2021-03-02 Thread Hans-Peter Nilsson via Gcc-patches
> From: Jeff Law > Date: Tue, 2 Mar 2021 23:39:27 +0100 > received-spf: None (smtp1.axis.com: no sender authenticity information > available from domain of postmas...@mail-il1-f172.google.com) identity=helo; > client-ip=209.85.166.172; receiver=smtp1.axis.com; > envelope-from="jeffreya...@g

Re: [PATCH] gcc.misc-tests/outputs.exp: assert unique test-names

2021-03-02 Thread Jeff Law via Gcc-patches
On 2/24/21 10:17 PM, Hans-Peter Nilsson via Gcc-patches wrote: > The gcc.misc-tests/outputs.exp tests can take some effort to > digest. > > Navigating and debugging causes for failing tests here isn't > helped by the existence of tests with duplicate names. > Let's stop that from happening. Thi

[PATCH] gcc.misc-tests/outputs.exp: assert unique test-names

2021-02-24 Thread Hans-Peter Nilsson via Gcc-patches
The gcc.misc-tests/outputs.exp tests can take some effort to digest. Navigating and debugging causes for failing tests here isn't helped by the existence of tests with duplicate names. Let's stop that from happening. This requires that test-run output is actually reviewed, as Tcl errors don't sto