On Feb 25, 2021, Hans-Peter Nilsson <h...@axis.com> wrote: > Navigating and debugging causes for failing tests here isn't > helped by the existence of tests with duplicate names.
Aah, I guess I see what happened: some test sets were copied to cover additional cases I hadn't covered (cool :-), but the test names were not changed. I wonder if we wouldn't be better off using say $bp instead of $b in test name strings, so that bp could be set to "$b whatever" or "$b" before a group of tests. This would make it easier to copy blocks of tests, but it would make it harder to search for a failing test. I suppose the changes you proposed, along with code that rejects duplicates, is preferrable: > gcc/testsuite: > * gcc.misc-tests/outputs.exp: Append discriminating > suffixes to tests with duplicate names. > (outest): Assert that each running test has a unique > name. LGTM, thanks! -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
