Re: [PATCH] fix more -Wformat-diag issues

2019-06-07 Thread Martin Sebor
On 6/7/19 6:57 AM, Christophe Lyon wrote: On Wed, 5 Jun 2019 at 20:33, Martin Sebor wrote: On 5/31/19 12:20 PM, Jeff Law wrote: On 5/31/19 9:56 AM, Martin Sebor wrote: On 5/30/19 5:49 PM, Jeff Law wrote: So in several places there's a comment which indicates that debugging dumps and the lik

Re: [PATCH] fix more -Wformat-diag issues

2019-06-07 Thread Christophe Lyon
On Wed, 5 Jun 2019 at 20:33, Martin Sebor wrote: > > On 5/31/19 12:20 PM, Jeff Law wrote: > > On 5/31/19 9:56 AM, Martin Sebor wrote: > >> On 5/30/19 5:49 PM, Jeff Law wrote: > >>> So in several places there's a comment which indicates that debugging > >>> dumps and the like do not follow conventi

Re: [PATCH] fix more -Wformat-diag issues

2019-06-06 Thread Martin Sebor
On 6/6/19 9:42 AM, Jakub Jelinek wrote: On Thu, Jun 06, 2019 at 08:45:56AM -0600, Martin Sebor wrote: Changes for the same change shouldn't be separated by empty newlines in the ChangeLog. Furthermore, you've managed to commit only the first part (until varasm.c) and not the rest. I actually

Re: [PATCH] fix more -Wformat-diag issues

2019-06-06 Thread Jakub Jelinek
On Thu, Jun 06, 2019 at 08:45:56AM -0600, Martin Sebor wrote: > > Changes for the same change shouldn't be separated by empty newlines in the > > ChangeLog. Furthermore, you've managed to commit only the first part (until > > varasm.c) and not the rest. > > I actually managed to do that on purpos

Re: [PATCH] fix more -Wformat-diag issues

2019-06-06 Thread Martin Sebor
On 6/6/19 3:39 AM, Jakub Jelinek wrote: On Wed, May 22, 2019 at 10:34:00AM -0600, Martin Sebor wrote: gcc/ChangeLog: * config/i386/i386-features.c (ix86_get_function_versions_dispatcher): Adjust quoting and hyphenation. * convert.c (convert_to_real_1): Same. * gc

Re: [PATCH] fix more -Wformat-diag issues

2019-06-06 Thread Jakub Jelinek
On Wed, May 22, 2019 at 10:34:00AM -0600, Martin Sebor wrote: > gcc/ChangeLog: > > * config/i386/i386-features.c (ix86_get_function_versions_dispatcher): > Adjust quoting and hyphenation. > * convert.c (convert_to_real_1): Same. > * gcc.c (driver_wrong_lang_callback): Same.

Re: [PATCH] fix more -Wformat-diag issues

2019-06-05 Thread Martin Sebor
On 5/31/19 12:20 PM, Jeff Law wrote: On 5/31/19 9:56 AM, Martin Sebor wrote: On 5/30/19 5:49 PM, Jeff Law wrote: So in several places there's a comment which indicates that debugging dumps and the like do not follow conventions.  Presumably you've tried to keep a narrow scope on the diagnostic

Re: [PATCH] fix more -Wformat-diag issues

2019-05-31 Thread Jeff Law
On 5/31/19 9:56 AM, Martin Sebor wrote: > On 5/30/19 5:49 PM, Jeff Law wrote: >> So in several places there's a comment which indicates that debugging >> dumps and the like do not follow conventions.  Presumably you've tried >> to keep a narrow scope on the diagnostic push/pops.  I'm also concerned

Re: [PATCH] fix more -Wformat-diag issues

2019-05-31 Thread Martin Sebor
On 5/30/19 5:49 PM, Jeff Law wrote: On 5/22/19 10:34 AM, Martin Sebor wrote: Incorporating the feedback I got on the -Wformat-diag checker provided an opportunity to tighten up existing and implement a small number of few additional rules based on GCC Coding Conventions (https://gcc.gnu.org/codi

Re: [PATCH] fix more -Wformat-diag issues

2019-05-30 Thread Jeff Law
On 5/22/19 10:34 AM, Martin Sebor wrote: > Incorporating the feedback I got on the -Wformat-diag checker > provided an opportunity to tighten up existing and implement > a small number of few additional rules based on GCC Coding > Conventions (https://gcc.gnu.org/codingconventions.html). > The chec

[PATCH] fix more -Wformat-diag issues

2019-05-22 Thread Martin Sebor
Incorporating the feedback I got on the -Wformat-diag checker provided an opportunity to tighten up existing and implement a small number of few additional rules based on GCC Coding Conventions (https://gcc.gnu.org/codingconventions.html). The checker now also warns for incorrect uses of the follo