On Thu, Jun 06, 2019 at 08:45:56AM -0600, Martin Sebor wrote: > > Changes for the same change shouldn't be separated by empty newlines in the > > ChangeLog. Furthermore, you've managed to commit only the first part (until > > varasm.c) and not the rest. > > I actually managed to do that on purpose. I just didn't "manage" > to also update the ever important ChangeLog. There are probably > other mistakes in it.
The coding conventions says not to, so have you violated that on purpose? https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs "Separate unrelated change log entries with blank lines. Don’t put blank lines between individual changes of an entry." I don't see any changes in that patch as unrelated, after all, if they were unrelated, they ought to be committed separately. Jakub
