Re: [PATCH] diagnostic_metadata: unbreak xgettext (v2)

2020-01-28 Thread David Malcolm
On Tue, 2020-01-28 at 16:34 +0100, Jakub Jelinek wrote: > On Tue, Jan 28, 2020 at 10:30:58AM -0500, David Malcolm wrote: > > gcc/analyzer/ChangeLog: > > * region-model.cc (poisoned_value_diagnostic::emit): Update for > > renaming of warning_at overload to warning_meta. > > * sm-file.cc

Re: [PATCH] diagnostic_metadata: unbreak xgettext (v2)

2020-01-28 Thread Jakub Jelinek
On Tue, Jan 28, 2020 at 10:30:58AM -0500, David Malcolm wrote: > gcc/analyzer/ChangeLog: > * region-model.cc (poisoned_value_diagnostic::emit): Update for > renaming of warning_at overload to warning_meta. > * sm-file.cc (file_leak::emit): Likewise. > * sm-malloc.cc (double_

[PATCH] diagnostic_metadata: unbreak xgettext (v2)

2020-01-28 Thread David Malcolm
On Tue, 2020-01-28 at 15:36 +0100, Jakub Jelinek wrote: > On Tue, Jan 28, 2020 at 09:30:17AM -0500, David Malcolm wrote: > > * diagnostic-core.h (warning_at): Rename overload to... > > (warning_with_metadata_at): ...this. > > I think this is just too long, especially for a function used at

Re: [PATCH] diagnostic_metadata: unbreak xgettext

2020-01-28 Thread Jakub Jelinek
On Tue, Jan 28, 2020 at 09:30:17AM -0500, David Malcolm wrote: > * diagnostic-core.h (warning_at): Rename overload to... > (warning_with_metadata_at): ...this. I think this is just too long, especially for a function used at least in the analyzer pretty often, leading to lots of ugly f

[PATCH] diagnostic_metadata: unbreak xgettext

2020-01-28 Thread David Malcolm
On Tue, 2020-01-28 at 11:16 +0100, Jakub Jelinek wrote: > On Wed, Dec 18, 2019 at 07:08:25PM -0500, David Malcolm wrote: > > This patch adds support for associating a diagnostic message with > > an > > optional diagnostic_metadata object, so that plugins can add extra > > data > > to their diagnost