On Tue, Jan 28, 2020 at 09:30:17AM -0500, David Malcolm wrote:
> * diagnostic-core.h (warning_at): Rename overload to...
> (warning_with_metadata_at): ...this.
I think this is just too long, especially for a function used at least
in the analyzer pretty often, leading to lots of ugly formatting.
Can't you use warning_meta or something similar instead?
> (emit_diagnostic_valist): Delete decl of overload taking
> diagnostic_metadata.
> * diagnostic.c (emit_diagnostic_valist): Likewise for defn.
> (warning_at): Rename overload taking diagnostic_metadata to...
> (warning_with_metadata_at): ...this.
Jakub
